From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 43099CA1012 for ; Sat, 6 Sep 2025 04:18:45 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.1113115.1461173 (Exim 4.92) (envelope-from ) id 1uukNa-0006aZ-R2; Sat, 06 Sep 2025 04:18:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1113115.1461173; Sat, 06 Sep 2025 04:18:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uukNa-0006aS-NS; Sat, 06 Sep 2025 04:18:22 +0000 Received: by outflank-mailman (input) for mailman id 1113115; Sat, 06 Sep 2025 04:18:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uukNZ-0006aM-7j for xen-devel@lists.xenproject.org; Sat, 06 Sep 2025 04:18:21 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.96) (envelope-from ) id 1uukNX-009RfV-1W; Sat, 06 Sep 2025 04:18:19 +0000 Received: from [19.12.91.86] (helo=localhost) by xenbits.xenproject.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uukNX-000JQ0-1C; Sat, 06 Sep 2025 04:18:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID :Subject:Cc:To:Date:From; bh=FFHTHv+ciDFyK8pkM0/CoPbfpYr0LBC0kpQLqatYuNY=; b= IWrlr0MQLmmD2KYQ1A6qbR23VAIodfM7Uj5HvGz9JofSIuUd9I00XnxebQf0RSdIYqHS9uuVjKu2V C7FUaI2F1uCRnrn6jFyhXc0MFpPGD2Q2v8GKYSSKNnzp1BYzCVHpninw6gjUuMFX1t26diguZMjB3 a7pXMgEPqFgWTzfXc=; From: dmukhin@xen.org Date: Fri, 5 Sep 2025 21:18:18 -0700 To: Stefano Stabellini Cc: xen-devel@lists.xenproject.org, andrew.cooper3@citrix.com, anthony.perard@vates.tech, jbeulich@suse.com, julien@xen.org, michal.orzel@amd.com, roger.pau@citrix.com, dmukhin@ford.com Subject: Re: [PATCH v6 03/15] emul/ns16x50: implement emulator stub Message-ID: References: <20250905232715.440758-1-dmukhin@ford.com> <20250905232715.440758-4-dmukhin@ford.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Sep 05, 2025 at 07:03:19PM -0700, Stefano Stabellini wrote: > On Fri, 5 Sep 2025, dmukhin@xen.org wrote: > > From: Denis Mukhin > > [..] > > --- a/xen/common/emul/vuart/Kconfig > > +++ b/xen/common/emul/vuart/Kconfig > > @@ -3,4 +3,23 @@ config VUART_FRAMEWORK > > > > menu "UART Emulation" > > > > +config VUART_NS16X50 > > + bool "NS16550-compatible UART Emulator" if EXPERT > > + depends on X86 && HVM > > + select VUART_FRAMEWORK > > + default n > > + help > > + In-hypervisor NS16x50 UART emulation. > > + > > + Only legacy PC COM2 port is emulated. > > + > > + This is strictly for testing purposes (such as early HVM guest console), > > + and not appropriate for use in production. > > + > > +config VUART_NS16X50_DEBUG > > + bool "NS16550-compatible UART Emulator Debugging" > > + depends on VUART_NS16X50 && DEBUG > > + help > > + Enable development debugging. > > There is a question about adding the kconfig option early in the series. > I think it would be best to add it as last patch Will do.