From: Yury Norov <yury.norov@gmail.com>
To: Ian Rogers <irogers@google.com>
Cc: "Rasmus Villemoes" <linux@rasmusvillemoes.dk>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Darren Hart" <dvhart@infradead.org>,
"Davidlohr Bueso" <dave@stgolabs.net>,
"André Almeida" <andrealmeid@igalia.com>,
"Arnaldo Carvalho de Melo" <acme@kernel.org>,
"Namhyung Kim" <namhyung@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
"Jiri Olsa" <jolsa@kernel.org>,
"Adrian Hunter" <adrian.hunter@intel.com>,
"Kan Liang" <kan.liang@linux.intel.com>,
"Ido Schimmel" <idosch@nvidia.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Jamal Hadi Salim" <jhs@mojatatu.com>,
"Jason Xing" <kerneljasonxing@gmail.com>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Yuyang Huang" <yuyanghuang@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
"Petr Machata" <petrm@nvidia.com>,
"Maurice Lambert" <mauricelambert434@gmail.com>,
"Jonas Gottlieb" <jonas.gottlieb@stackit.cloud>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
bpf@vger.kernel.org
Subject: Re: [PATCH v1 2/4] tools bitmap: Add missing asm-generic/bitsperlong.h include
Date: Sat, 6 Sep 2025 10:35:58 -0400 [thread overview]
Message-ID: <aLxGztswgpjxlt2l@yury> (raw)
In-Reply-To: <20250905224708.2469021-3-irogers@google.com>
On Fri, Sep 05, 2025 at 03:47:06PM -0700, Ian Rogers wrote:
> small_const_nbits is defined in asm-generic/bitsperlong.h which
> bitmap.h uses but doesn't include causing build failures in some build
> systems. Add the missing #include.
>
> Note the bitmap.h in tools has diverged from that of the kernel, so no
> changes are made there.
>
> Signed-off-by: Ian Rogers <irogers@google.com>
Acked-by: Yury Norov (NVIDIA) <yury.norov@gmail.com>
> ---
> tools/include/linux/bitmap.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/include/linux/bitmap.h b/tools/include/linux/bitmap.h
> index d4d300040d01..0d992245c600 100644
> --- a/tools/include/linux/bitmap.h
> +++ b/tools/include/linux/bitmap.h
> @@ -3,6 +3,7 @@
> #define _TOOLS_LINUX_BITMAP_H
>
> #include <string.h>
> +#include <asm-generic/bitsperlong.h>
> #include <linux/align.h>
> #include <linux/bitops.h>
> #include <linux/find.h>
> --
> 2.51.0.355.g5224444f11-goog
next prev parent reply other threads:[~2025-09-06 14:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-05 22:47 [PATCH v1 0/4] perf/tools build related fixes Ian Rogers
2025-09-05 22:47 ` [PATCH v1 1/4] perf bench futex: Add missing stdbool.h Ian Rogers
2025-09-05 22:47 ` [PATCH v1 2/4] tools bitmap: Add missing asm-generic/bitsperlong.h include Ian Rogers
2025-09-06 14:35 ` Yury Norov [this message]
2025-09-05 22:47 ` [PATCH v1 3/4] tools include: Replace tools linux/gfp_types.h with kernel version Ian Rogers
2025-09-05 22:47 ` [PATCH v1 4/4] tools include: Add headers to make tools builds more hermetic Ian Rogers
2025-10-02 18:13 ` [PATCH v1 0/4] perf/tools build related fixes Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aLxGztswgpjxlt2l@yury \
--to=yury.norov@gmail.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=andrealmeid@igalia.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=dave@stgolabs.net \
--cc=davem@davemloft.net \
--cc=dvhart@infradead.org \
--cc=idosch@nvidia.com \
--cc=irogers@google.com \
--cc=jhs@mojatatu.com \
--cc=jolsa@kernel.org \
--cc=jonas.gottlieb@stackit.cloud \
--cc=kan.liang@linux.intel.com \
--cc=kerneljasonxing@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=mark.rutland@arm.com \
--cc=mauricelambert434@gmail.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=pabeni@redhat.com \
--cc=peterz@infradead.org \
--cc=petrm@nvidia.com \
--cc=tglx@linutronix.de \
--cc=yuyanghuang@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.