Re: [PATCH] qom: use ERRP_GUARD in user_creatable_complete

["Daniel P. Berrangé" <berrange@redhat.com>]

On Fri, Sep 19, 2025 at 01:30:18PM +0200, Markus Armbruster wrote:
> Daniel P. Berrangé <berrange@redhat.com> writes:
> 
> > With error_propagate, the stack trace from any error_abort/fatal
> > usage will start from the error_propagate() call, which is largely
> > useless. Using ERRP_GUARD ensures the stack trace starts from
> > the origin that reported the error.
> 
> Yes.
> 
> I've been chipping at error_propagate() uses on and off for a while.
> There are hundreds left.

Are there cases where it is still OK to use error_propagate or should
we be looking to eliminate all its usage ?


> 
> > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> 
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
> 

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|