From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6170FCAC59A for ; Fri, 19 Sep 2025 13:51:21 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uzbVY-0006ZQ-Al; Fri, 19 Sep 2025 09:50:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uzbVS-0006XM-7Y for qemu-devel@nongnu.org; Fri, 19 Sep 2025 09:50:34 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uzbVF-0000m2-DL for qemu-devel@nongnu.org; Fri, 19 Sep 2025 09:50:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758289817; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wQgGuSbOfRlKoQwg1JHloZA0cq6M6zIs7B1AY8sNAN0=; b=W4Wq0dje9TwTXtKIB9sqYrxVQhMDcM5bkQH5Xtyp6zJJ3JecmK6VpTpUai3TvvtbBq6AYX Lbo4vF87KNHO4ycyh0ToeQDzfk2he949n8K703Wch0YESI0KMDVhWnzPYLyNfjdiwzY662 XT3xDBHJledIFKIa2DpRJeyCPWBm90Y= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-153-aLiy7mMCMDSN2WpSYSpXgw-1; Fri, 19 Sep 2025 09:50:13 -0400 X-MC-Unique: aLiy7mMCMDSN2WpSYSpXgw-1 X-Mimecast-MFC-AGG-ID: aLiy7mMCMDSN2WpSYSpXgw_1758289812 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5730C19560B6; Fri, 19 Sep 2025 13:50:12 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.187]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9F961180035E; Fri, 19 Sep 2025 13:50:08 +0000 (UTC) Date: Fri, 19 Sep 2025 14:50:05 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: marcandre.lureau@redhat.com Cc: qemu-devel@nongnu.org, Jiaxun Yang , Ed Maste , Thomas Huth , Li-Wen Hsu , Yonggang Luo , Warner Losh , Alex =?utf-8?Q?Benn=C3=A9e?= , Paolo Bonzini , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Kohei Tokunaga , Kyle Evans Subject: Re: [PATCH 02/24] scripts/archive-source: speed up downloading subprojects Message-ID: References: <20250919133320.240145-1-marcandre.lureau@redhat.com> <20250919133320.240145-3-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250919133320.240145-3-marcandre.lureau@redhat.com> User-Agent: Mutt/2.2.14 (2025-02-20) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, T_SPF_HELO_TEMPERROR=0.01, T_SPF_TEMPERROR=0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Fri, Sep 19, 2025 at 05:32:56PM +0400, marcandre.lureau@redhat.com wrote: > From: Marc-André Lureau > > Running meson on each subproject is quite slow. Why is this faster ? Does it make meson do parallel downloads if you list then all at once ? > > Signed-off-by: Marc-André Lureau > --- > scripts/archive-source.sh | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/scripts/archive-source.sh b/scripts/archive-source.sh > index 035828c532..85cd0a63a0 100755 > --- a/scripts/archive-source.sh > +++ b/scripts/archive-source.sh > @@ -77,9 +77,10 @@ function subproject_dir() { > git archive --format tar "$(tree_ish)" > "$tar_file" > test $? -ne 0 && error "failed to archive qemu" > > +meson subprojects download $subprojects > +test $? -ne 0 && error "failed to download subprojects $subprojects" > + > for sp in $subprojects; do > - meson subprojects download $sp > - test $? -ne 0 && error "failed to download subproject $sp" > tar --append --file "$tar_file" --exclude=.git subprojects/"$(subproject_dir $sp)" > test $? -ne 0 && error "failed to append subproject $sp to $tar_file" > done > -- > 2.51.0 > With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|