All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Adrian Barnaś" <abarnas@google.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Dylan Hatch <dylanbhatch@google.com>,
	Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH 0/2] arm64: modules: Reject loading of malformed modules
Date: Fri, 19 Sep 2025 13:50:37 +0000	[thread overview]
Message-ID: <aM1frYteFpv1zVr7@google.com> (raw)
In-Reply-To: <CAMj1kXGe=HR7EvMs8D=7Uvr4Vhr7fXp56YQ9A10xdF1V1M71zw@mail.gmail.com>

On Fri, Sep 19, 2025 at 03:17:29PM +0200, Ard Biesheuvel wrote:
>Hello Adrian,
>
>On Fri, 19 Sept 2025 at 14:23, Adrian Barnaś <abarnas@google.com> wrote:
>>
>> Hi,
>>
>> Here are a couple of patches to reject the loading of malformed modules
>> on arm64 when the SCS patching is only partially applied or we detect
>> an alternative callback function used in the module text.
>>
>> The SCS issue is largely theoretical. The code currently performs
>> a "dry-run" (which we remove), and leave module code as-is if failed.
>> However the latter issue was reported to crash the kernel at [1].
>>
>
>Why are you fixing this largely theoretical issue along with the
>callback alternatives patching? The referenced thread only talks about
>the latter, right?

Hello Ard,

You are right that the reference thread is only about the alternative
callback issue in modules. We found the potential SCS issue while fixing 
this. Proposed resolutions are symmetrical. That's why it is in a single
patch set.

If you find it incorrect I can split it into two separate patches.

Thanks,
Adrian


      reply	other threads:[~2025-09-19 13:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-19 12:23 [PATCH 0/2] arm64: modules: Reject loading of malformed modules Adrian Barnaś
2025-09-19 12:23 ` [PATCH 1/2] arch: arm64: Fail module loading if dynamic SCS patching fails Adrian Barnaś
2025-09-19 13:59   ` Ard Biesheuvel
2025-09-19 14:47     ` Adrian Barnaś
2025-09-19 12:23 ` [PATCH 2/2] arch: arm64: Reject modules with internal alternative callbacks Adrian Barnaś
2025-09-19 15:01   ` Ard Biesheuvel
2025-09-19 16:39     ` Adrian Barnaś
2025-09-20  0:46   ` kernel test robot
2025-09-19 13:17 ` [PATCH 0/2] arm64: modules: Reject loading of malformed modules Ard Biesheuvel
2025-09-19 13:50   ` Adrian Barnaś [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aM1frYteFpv1zVr7@google.com \
    --to=abarnas@google.com \
    --cc=ardb@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=dylanbhatch@google.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.