From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BB63BCAC583 for ; Tue, 9 Sep 2025 13:39:14 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2841C10E744; Tue, 9 Sep 2025 13:39:14 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="UppggZ7L"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8B59810E744 for ; Tue, 9 Sep 2025 13:39:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1757425153; x=1788961153; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=G1YWknukSgFVvObigngVHnHpzeP2fXGCBKhsmC0D2aU=; b=UppggZ7LDCBrCoEoQqKL/LqvNvr2Ss/fAqQRWWbXqFPuk3tjlCJP16Ej RkkJPSosxlewYS2c+QpTcF/cKJwKrXoddcehSsp2Y4lHnaO2SjMNXKh66 k2SduILhHb8juPIhDgQOjICnGyOyAVYhXZ+IHtrU2McIwCTlXyMF2jm2U 2PmuE7xwYjWzng2xLCEJKKrQ0eRWv8uZA2LPhVrOWGiM4Ap2BNJTrU0M4 /toajb1s/GqUujwRUEp16BvgusipX1o4X9TaEmRcbVlqIn0QiP21z0ss8 54w/l9F5qI79tkjdUqdKavC4f3drtJ62FDl7FEwnjuwpWozJjyDjGLWJM g==; X-CSE-ConnectionGUID: i8lt/SQ5S7G+u+yj5i468Q== X-CSE-MsgGUID: o+xtYoZ9Q1Co6ZhHdIBDWA== X-IronPort-AV: E=McAfee;i="6800,10657,11548"; a="71126244" X-IronPort-AV: E=Sophos;i="6.18,251,1751266800"; d="scan'208";a="71126244" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Sep 2025 06:39:13 -0700 X-CSE-ConnectionGUID: ynpV/gVkQbi5g9TnkYwE+Q== X-CSE-MsgGUID: R4QO1tRoS366vb0Wtoc+QA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.18,251,1751266800"; d="scan'208";a="172363755" Received: from dalessan-mobl3.ger.corp.intel.com (HELO localhost) ([10.245.244.181]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Sep 2025 06:39:10 -0700 Date: Tue, 9 Sep 2025 16:39:07 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Maxime Ripard Cc: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, Russell King Subject: Re: [PATCH v3 13/39] drm/armada: Drop always true condition in atomic_check Message-ID: References: <20250909-drm-no-more-existing-state-v3-0-1c7a7d960c33@kernel.org> <20250909-drm-no-more-existing-state-v3-13-1c7a7d960c33@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250909-drm-no-more-existing-state-v3-13-1c7a7d960c33@kernel.org> X-Patchwork-Hint: comment Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Sep 09, 2025 at 01:27:32PM +0200, Maxime Ripard wrote: > The drm_atomic_state pointer passed to atomic_check is always valid, so > checking if it's NULL or not is pointless. Remove the check. > > Suggested-by: Ville Syrjälä > Signed-off-by: Maxime Ripard > > --- > To: Russell King > --- > drivers/gpu/drm/armada/armada_plane.c | 9 ++------- > 1 file changed, 2 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/armada/armada_plane.c b/drivers/gpu/drm/armada/armada_plane.c > index cc47c032dbc151a463cbd0b0d048c74c2828f253..976b6a271c912421e3fec7525f77234e73a74212 100644 > --- a/drivers/gpu/drm/armada/armada_plane.c > +++ b/drivers/gpu/drm/armada/armada_plane.c > @@ -83,25 +83,20 @@ int armada_drm_plane_atomic_check(struct drm_plane *plane, > { > struct drm_plane_state *new_plane_state = drm_atomic_get_new_plane_state(state, > plane); > struct armada_plane_state *st = to_armada_plane_state(new_plane_state); > struct drm_crtc *crtc = new_plane_state->crtc; > - struct drm_crtc_state *crtc_state; > + struct drm_crtc_state *crtc_state = > + drm_atomic_get_existing_crtc_state(state, crtc); new_plane_state->crtc might be NULL here. > bool interlace; > int ret; > > if (!new_plane_state->fb || WARN_ON(!new_plane_state->crtc)) { > new_plane_state->visible = false; > return 0; > } > Here we know it's not NULL. > - if (state) > - crtc_state = drm_atomic_get_existing_crtc_state(state, > - crtc); > - else > - crtc_state = crtc->state; > - > ret = drm_atomic_helper_check_plane_state(new_plane_state, crtc_state, > 0, > INT_MAX, true, false); > if (ret) > return ret; > > -- > 2.50.1 -- Ville Syrjälä Intel