From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 683F4CA0FED for ; Tue, 9 Sep 2025 16:02:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=/qoMRE1vi11Zuhe4l1j99YSHLSz5fh33wcsaq+ocs00=; b=Ep2kzU0JLIBE4SheYD4ru50QMH vM4/OUrAPVB4BUXYd6+3fvwt1BugLEexCCPAq1aW4MSOFfUT58RYo2icvpOKLzfxG690ZkGltG04j OUl9S/4lMXaYWsu3hPsUxcfiu/NVUzWjHZoMeJi4rE/eKLc1I5mMpmlYVwlmZT93NL2ljMFlfEOHO Sub27aOLiAyfYrs9r3GxZrwr2ge62eCS8+yd8f4s5sP5pgBls6uNtAGBOtmNM0oOJn65f1nwdB7xv b2xQ+cqEgtJgUHEJHDuq3oxojMgcSFKEwUfayuj5YoQTK3Em31MEQK6dvIi2buDTNcb51EbOaxkPL 5H6etwTg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uw0nq-00000008OAm-2QTd; Tue, 09 Sep 2025 16:02:42 +0000 Received: from mail-wr1-x449.google.com ([2a00:1450:4864:20::449]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uvybA-00000007T3x-2TK3 for linux-riscv@lists.infradead.org; Tue, 09 Sep 2025 13:41:29 +0000 Received: by mail-wr1-x449.google.com with SMTP id ffacd0b85a97d-3e751508f3aso481640f8f.0 for ; Tue, 09 Sep 2025 06:41:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1757425285; x=1758030085; darn=lists.infradead.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=vGCVFLl/bZU4VqXRso3PPgDeP8aVgDKQ3+zbC69nRRQ=; b=VP6L4AOYTI/d15F9D5eDBhOYG5jeFa4W432UIhGKA015u/viHYrL/Bc1JoEyf1w076 +aSmK6yarnG4P78QVG4xFxgrHICWIJADOabMkJW03gMTQY+ZCVMGcX0KPtR8ByEbCWck Ph0KlzJGLqa+9MaCOfAa6Awjc8g3F33pD/KZKaF11ZtBlqufurb6ShVkS0t52Vvu458D zLqzo3FS7ia1nZv09/EpmXPtrIEWLMB0OMkUp8MQw385D+jbBhchDBFKm1V2zTuH33ZW je2p0duEiokhj96eYv5AOdvk4DMVswsyzHdzKoaQtkUYwDiRUFwiPXHYVdyEgW7uEOpK QHgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757425285; x=1758030085; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=vGCVFLl/bZU4VqXRso3PPgDeP8aVgDKQ3+zbC69nRRQ=; b=Fuybm8wOG20eYKXUH9RytlTgaemb2+EJ77PpxcMsDXnktT9tjsSG6SWJ4rZpjd05ms EN4uTSk4ftHtCSd7va52GtdLMya4c13YzHFuvOBVbwT5TwvyBdD8vPFvMFBGbbqcoxp6 fkeJEUIwPgRe8cDKP0wF2eCNfvh9HcRSwzbsNSv0AEjoOBYRR2OCGEPpX0MCd84nn1JE g5NpCTxz4bhabsIhxp5J9KXxiurN2oNxzLmT3CLb/69WbVeKtK6YjPiuzZniKesPpKxc cMCj5kpb0hGPeb81MNBUquTkvUYp+GdAYipcEUsTMoXSRkEsB9TE2OMnKICpoVYwOlye M5yw== X-Forwarded-Encrypted: i=1; AJvYcCVuAO4IlG9+A9oVsDOh8FVJc6F6HcJ5WjHon2Vnep0O6GilwuMhx8/HqOc0tF9jvnqZmBVGrp1B4ofe5w==@lists.infradead.org X-Gm-Message-State: AOJu0Yzn2ZCKbSy2K4LQvX9q1UWUnQ85TwKnhITO7GS5VYIsGkjv0HA4 vq1OiFvoBWNYxd+iMwcwCv/JMuiWLdyxloVPPA1kwBY0ExE2W5GVdNNGGLDe4M0fzPyCIEloLNv qUV9fk9aDlGVqJcY5hQ== X-Google-Smtp-Source: AGHT+IE/mmAbQTOt8MvZZNGslJ2H2GmSSbN9MpzaubBetSPclclKq6OgKdnhJfvpCbHxNnnHv8DltcQ3KGr2Jow= X-Received: from wrwa18.prod.google.com ([2002:a5d:53d2:0:b0:3d7:c499:56f]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6000:2f87:b0:3d7:df92:5e31 with SMTP id ffacd0b85a97d-3e641e3b09amr11045695f8f.16.1757425285136; Tue, 09 Sep 2025 06:41:25 -0700 (PDT) Date: Tue, 9 Sep 2025 13:41:24 +0000 In-Reply-To: <202509082009.4A8DC97BD2@keescook> Mime-Version: 1.0 References: <20250908-distill-lint-1ae78bcf777c@spud> <202509082009.4A8DC97BD2@keescook> Message-ID: Subject: Re: [PATCH v1] rust: cfi: only 64-bit arm and x86 support CFI_CLANG From: Alice Ryhl To: Kees Cook Cc: Conor Dooley , linux-kernel@vger.kernel.org, Conor Dooley , stable@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , Alexandre Ghiti , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , "=?utf-8?B?QmrDtnJu?= Roy Baron" , Benno Lossin , Andreas Hindborg , Trevor Gross , Danilo Krummrich , Sami Tolvanen , Matthew Maurer , "Peter Zijlstra (Intel)" , linux-riscv@lists.infradead.org, rust-for-linux@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250909_064128_645907_708653C7 X-CRM114-Status: GOOD ( 29.80 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gTW9uLCBTZXAgMDgsIDIwMjUgYXQgMDg6MTE6NDhQTSAtMDcwMCwgS2VlcyBDb29rIHdyb3Rl Ogo+IE9uIE1vbiwgU2VwIDA4LCAyMDI1IGF0IDAyOjEyOjM1UE0gKzAxMDAsIENvbm9yIERvb2xl eSB3cm90ZToKPiA+IEZyb206IENvbm9yIERvb2xleSA8Y29ub3IuZG9vbGV5QG1pY3JvY2hpcC5j b20+Cj4gPiAKPiA+IFRoZSBrZXJuZWwgdXNlcyB0aGUgc3RhbmRhcmQgcnVzdGMgdGFyZ2V0cyBm b3Igbm9uLXg4NiB0YXJnZXRzLCBhbmQgb3V0Cj4gPiBvZiB0aG9zZSBvbmx5IDY0LWJpdCBhcm0n cyB0YXJnZXQgaGFzIGtjZmkgc3VwcG9ydCBlbmFibGVkLiBGb3IgeDg2LCB0aGUKPiA+IGN1c3Rv bSA2NC1iaXQgdGFyZ2V0IGVuYWJsZXMga2NmaS4KPiA+IAo+ID4gVGhlIEhBVkVfQ0ZJX0lDQUxM X05PUk1BTElaRV9JTlRFR0VSU19SVVNUQyBjb25maWcgb3B0aW9uIHRoYXQgYWxsb3dzCj4gPiBD RklfQ0xBTkcgdG8gYmUgdXNlZCBpbiBjb21iaW5hdGlvbiB3aXRoIFJVU1QgZG9lcyBub3QgY2hl Y2sgd2hldGhlciB0aGUKPiA+IHJ1c3RjIHRhcmdldCBzdXBwb3J0cyBrY2ZpLiBUaGlzIGJyZWFr cyB0aGUgYnVpbGQgb24gcmlzY3YgKGFuZAo+ID4gcHJlc3VtYWJseSAzMi1iaXQgYXJtKSB3aGVu IENGSV9DTEFORyBhbmQgUlVTVCBhcmUgZW5hYmxlZCBhdCB0aGUgc2FtZQo+ID4gdGltZS4KPiA+ IAo+ID4gT3JkaW5hcmlseSwgYSBydXN0Yy1vcHRpb24gY2hlY2sgd291bGQgYmUgdXNlZCB0byBk ZXRlY3QgdGFyZ2V0IHN1cHBvcnQKPiA+IGJ1dCB1bmZvcnR1bmF0ZWx5IHJ1c3RjLW9wdGlvbiBm aWx0ZXJzIG91dCB0aGUgdGFyZ2V0IGZvciByZWFzb25zIGdpdmVuCj4gPiBpbiBjb21taXQgNDZl MjRhNTQ1Y2RiNCAoInJ1c3Q6IGthc2FuL2tidWlsZDogZml4IG1pc3NpbmcgZmxhZ3Mgb24gZmly c3QKPiA+IGJ1aWxkIikuIEFzIGEgcmVzdWx0LCBpZiB0aGUgaG9zdCBzdXBwb3J0cyBrY2ZpIGJ1 dCB0aGUgdGFyZ2V0IGRvZXMgbm90LAo+ID4gZS5nLiB3aGVuIGJ1aWxkaW5nIGZvciByaXNjdiBv biB4ODZfNjQsIHRoZSBidWlsZCB3b3VsZCByZW1haW4gYnJva2VuLgo+ID4gCj4gPiBJbnN0ZWFk LCBtYWtlIEhBVkVfQ0ZJX0lDQUxMX05PUk1BTElaRV9JTlRFR0VSU19SVVNUQyBkZXBlbmQgb24g dGhlIG9ubHkKPiA+IHR3byBhcmNoaXRlY3R1cmVzIHdoZXJlIHRoZSB0YXJnZXQgdXNlZCBzdXBw b3J0cyBpdCB0byBmaXggdGhlIGJ1aWxkLgo+IAo+IEknbSBnZW5lcmFsbHkgZmluZSB3aXRoIHRo aXMsIGJ1dCBub3JtYWxseSB3ZSBkbyBhcmNoLXNwZWNpZmljIHN0dWZmCj4gb25seSBpbiBhcmNo LyRhcmNoL0tjb25maWcsIGFuZCBleHBvc2Ugc29tZSBraW5kIG9mCj4gQVJDSF9IQVNfQ0ZJX0lD QUxMX05PUk1BTElaRV9JTlRFR0VSUyB0aGF0IHdvdWxkIGdldCB0ZXN0ZWQgaGVyZS4gU2hvdWxk Cj4gd2UgZG8gdGhhdCBoZXJlIHRvbz8KCkknbSB0aGlua2luZyBpbiB0aGlzIGNhc2UgaXQgbWFr ZXMgc2Vuc2UgdG8ga2VlcCB0aGlzIHBhdGNoIHNpbXBsZSBhcwppdCdzIGEgZml4LiBPbmNlIHJ1 c3RjIHN1cHBvcnRzIGNmaSBvbiByaXNjdiAod2hpY2ggc2hvdWxkIHJlYWxseSBqdXN0CmJlIGNo YW5naW5nIHRoZSB0YXJnZXQgdG8gbGlzdCBpdCBhcyBzdXBwb3J0ZWQpLCB3ZSBjYW4gcmVvcmdh bml6ZSBpdCB0bwptYXRjaCB3aGF0IHlvdSdyZSBkZXNjcmliaW5nIGF0IHRoYXQgcG9pbnQuCgo+ ID4gQ0M6IHN0YWJsZUB2Z2VyLmtlcm5lbC5vcmcKPiA+IEZpeGVzOiBjYTYyN2U2MzY1NTFlICgi cnVzdDogY2ZpOiBhZGQgc3VwcG9ydCBmb3IgQ0ZJX0NMQU5HIHdpdGggUnVzdCIpCj4gPiBTaWdu ZWQtb2ZmLWJ5OiBDb25vciBEb29sZXkgPGNvbm9yLmRvb2xleUBtaWNyb2NoaXAuY29tPgo+ID4g LS0tCj4gPiBDQzogUGF1bCBXYWxtc2xleSA8cGF1bC53YWxtc2xleUBzaWZpdmUuY29tPgo+ID4g Q0M6IFBhbG1lciBEYWJiZWx0IDxwYWxtZXJAZGFiYmVsdC5jb20+Cj4gPiBDQzogQWxleGFuZHJl IEdoaXRpIDxhbGV4QGdoaXRpLmZyPgo+ID4gQ0M6IE1pZ3VlbCBPamVkYSA8b2plZGFAa2VybmVs Lm9yZz4KPiA+IENDOiBBbGV4IEdheW5vciA8YWxleC5nYXlub3JAZ21haWwuY29tPgo+ID4gQ0M6 IEJvcXVuIEZlbmcgPGJvcXVuLmZlbmdAZ21haWwuY29tPgo+ID4gQ0M6IEdhcnkgR3VvIDxnYXJ5 QGdhcnlndW8ubmV0Pgo+ID4gQ0M6ICJCasO2cm4gUm95IEJhcm9uIiA8Ympvcm4zX2doQHByb3Rv bm1haWwuY29tPgo+ID4gQ0M6IEJlbm5vIExvc3NpbiA8bG9zc2luQGtlcm5lbC5vcmc+Cj4gPiBD QzogQW5kcmVhcyBIaW5kYm9yZyA8YS5oaW5kYm9yZ0BrZXJuZWwub3JnPgo+ID4gQ0M6IEFsaWNl IFJ5aGwgPGFsaWNlcnlobEBnb29nbGUuY29tPgo+ID4gQ0M6IFRyZXZvciBHcm9zcyA8dG1ncm9z c0B1bWljaC5lZHU+Cj4gPiBDQzogRGFuaWxvIEtydW1tcmljaCA8ZGFrckBrZXJuZWwub3JnPgo+ ID4gQ0M6IEtlZXMgQ29vayA8a2Vlc0BrZXJuZWwub3JnPgo+ID4gQ0M6IFNhbWkgVG9sdmFuZW4g PHNhbWl0b2x2YW5lbkBnb29nbGUuY29tPgo+ID4gQ0M6IE1hdHRoZXcgTWF1cmVyIDxtbWF1cmVy QGdvb2dsZS5jb20+Cj4gPiBDQzogIlBldGVyIFppamxzdHJhIChJbnRlbCkiIDxwZXRlcnpAaW5m cmFkZWFkLm9yZz4KPiA+IENDOiBsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnCj4gPiBDQzog bGludXgtcmlzY3ZAbGlzdHMuaW5mcmFkZWFkLm9yZwo+ID4gQ0M6IHJ1c3QtZm9yLWxpbnV4QHZn ZXIua2VybmVsLm9yZwo+ID4gLS0tCj4gPiAgYXJjaC9LY29uZmlnIHwgMSArCj4gPiAgMSBmaWxl IGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9hcmNoL0tjb25m aWcgYi9hcmNoL0tjb25maWcKPiA+IGluZGV4IGQxYjRmZmQ2ZTA4NTYuLjg4MGNkZGZmNWVkYTcg MTAwNjQ0Cj4gPiAtLS0gYS9hcmNoL0tjb25maWcKPiA+ICsrKyBiL2FyY2gvS2NvbmZpZwo+ID4g QEAgLTkxNyw2ICs5MTcsNyBAQCBjb25maWcgSEFWRV9DRklfSUNBTExfTk9STUFMSVpFX0lOVEVH RVJTX1JVU1RDCj4gPiAgCWRlZl9ib29sIHkKPiA+ICAJZGVwZW5kcyBvbiBIQVZFX0NGSV9JQ0FM TF9OT1JNQUxJWkVfSU5URUdFUlNfQ0xBTkcKPiA+ICAJZGVwZW5kcyBvbiBSVVNUQ19WRVJTSU9O ID49IDEwNzkwMAo+ID4gKwlkZXBlbmRzIG9uIEFSTTY0IHx8IFg4Nl82NAo+ID4gIAkjIFdpdGgg R0NPVi9LQVNBTiB3ZSBuZWVkIHRoaXMgZml4OiBodHRwczovL2dpdGh1Yi5jb20vcnVzdC1sYW5n L3J1c3QvcHVsbC8xMjkzNzMKPiA+ICAJZGVwZW5kcyBvbiAoUlVTVENfTExWTV9WRVJTSU9OID49 IDE5MDEwMyAmJiBSVVNUQ19WRVJTSU9OID49IDEwODIwMCkgfHwgXAo+ID4gIAkJKCFHQ09WX0tF Uk5FTCAmJiAhS0FTQU5fR0VORVJJQyAmJiAhS0FTQU5fU1dfVEFHUykKPiA+IC0tIAo+ID4gMi40 Ny4yCj4gPiAKPiAKPiAtLSAKPiBLZWVzIENvb2sKCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmxpbnV4LXJpc2N2IG1haWxpbmcgbGlzdApsaW51eC1yaXNj dkBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4v bGlzdGluZm8vbGludXgtcmlzY3YK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f73.google.com (mail-wr1-f73.google.com [209.85.221.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24734356913 for ; Tue, 9 Sep 2025 13:41:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757425289; cv=none; b=QYrvScmFoFNkYrSNy7EuG3A39kdXYcjtZf+XQelmbZ7Y3XODKsT3m8LyHNy4wHXo/dTWF1vDu9PpN57EmFO3E5PamvzulJLElRNgWoJkMODV4O5DL2WpDqOLAsvQU/kvxwRJFqljlx2p0CxGRSQxKiDXZl2pEOk81cXIHMWQTMI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757425289; c=relaxed/simple; bh=hxrA1u0i3QdX2WF0YP/9Yngh01/0dr4Fi2cGW2VCD8E=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=EdZjIuNB5r2cwPlVGpPtBRMUHA9Xgvni6GNrMRoOjOhgqKLD9blkkSL93/FY4MtuNkzSTWDVzuVfafwGtD34Vpj4UIKpnXXxPRQv9eXxQUcZPv/cjDP6IbKQg9LkFS6iKt7w1zJiE6BEGyFJQ57cBF94DJvnJ6Qi6WuoUgR8A0k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=XcKQPw8r; arc=none smtp.client-ip=209.85.221.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="XcKQPw8r" Received: by mail-wr1-f73.google.com with SMTP id ffacd0b85a97d-3df07c967e9so3489442f8f.2 for ; Tue, 09 Sep 2025 06:41:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1757425285; x=1758030085; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=vGCVFLl/bZU4VqXRso3PPgDeP8aVgDKQ3+zbC69nRRQ=; b=XcKQPw8r/C6D5PvmnmJ556JFF0M9xQeWw2enHjc+itOEQlB7IZz4k2Ytdir556DluM lc6BO/eQtitx1pV5po/LvND1m+2ZaHPjzF5O0BbLTikha7p0AfqD5XbsiPTRA4n8VE5Z VyUw2lXwtNOrzeFGNw7f5SopgM3eP9Yqw21+YQYsnCG6VgqpzcxA9A+3kJLEkFcQvQIR WsY8RJV2+8iSAifgTxjav6z0E37jlLvzd+cnYrldJfmw6VqhWAziKJ0SLxHwkGrYLT4v W/aaGpIwEYbYkGMJYWzjnvTmoihy1l0cKXFO5XT72g7m7z6AXCeK5fhD+zvhxij2NuM4 2B6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757425285; x=1758030085; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=vGCVFLl/bZU4VqXRso3PPgDeP8aVgDKQ3+zbC69nRRQ=; b=DlzS5LAQstUUI8UsHiWMwB9ORY6JgaBwNDfzGjjjHFmXlB3M6+k61FSEBRQkMvAsnD QewDw/dTgOxInZC/BIy+dviz9zLPH3Xw9UgEOdGMln6xil0VxT/v8zr1UiXOQgxgK6IE Qr2tTz5EotozrgvAPwINpPWjUPYt61CZ4GVq2ZXiL5SMZ+hRCc00KaNPDHX2qP10G2k5 X5UxFtF+b6MBkQl/8FsiAELWe81oNEfegicXy3UZFQTXnKvWefF+KfND1Dv2Pr4+Xg9u DbiF1j9CL4uSSpSWziiNMFDQNwsBnNv7/4Julcdiw69QoxNmI+JA1V0niwUp+8mLkion V5ow== X-Forwarded-Encrypted: i=1; AJvYcCUT8XtBC3ZAalVMTDgrkiyqOBBXpgP+x3FevlX9Fzteqe5QquQ8dbL8q2d9bL6w3T5yogAnyA5ygTVm5s+SSg==@vger.kernel.org X-Gm-Message-State: AOJu0YyfXrJhKNDNAOpM2/lgWKHxdLzR/o9YEFyvX330zimeU4aCEiCo jFSJkmQn9cybSuA2W0+dehI8lqJy4SUriJ22ENhCtnBETrguZfMArrXKzpeip7uoL48R7i71jhr WV/NvgPb4NCY7MY/avA== X-Google-Smtp-Source: AGHT+IE/mmAbQTOt8MvZZNGslJ2H2GmSSbN9MpzaubBetSPclclKq6OgKdnhJfvpCbHxNnnHv8DltcQ3KGr2Jow= X-Received: from wrwa18.prod.google.com ([2002:a5d:53d2:0:b0:3d7:c499:56f]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6000:2f87:b0:3d7:df92:5e31 with SMTP id ffacd0b85a97d-3e641e3b09amr11045695f8f.16.1757425285136; Tue, 09 Sep 2025 06:41:25 -0700 (PDT) Date: Tue, 9 Sep 2025 13:41:24 +0000 In-Reply-To: <202509082009.4A8DC97BD2@keescook> Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250908-distill-lint-1ae78bcf777c@spud> <202509082009.4A8DC97BD2@keescook> Message-ID: Subject: Re: [PATCH v1] rust: cfi: only 64-bit arm and x86 support CFI_CLANG From: Alice Ryhl To: Kees Cook Cc: Conor Dooley , linux-kernel@vger.kernel.org, Conor Dooley , stable@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , Alexandre Ghiti , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , "=?utf-8?B?QmrDtnJu?= Roy Baron" , Benno Lossin , Andreas Hindborg , Trevor Gross , Danilo Krummrich , Sami Tolvanen , Matthew Maurer , "Peter Zijlstra (Intel)" , linux-riscv@lists.infradead.org, rust-for-linux@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Mon, Sep 08, 2025 at 08:11:48PM -0700, Kees Cook wrote: > On Mon, Sep 08, 2025 at 02:12:35PM +0100, Conor Dooley wrote: > > From: Conor Dooley > >=20 > > The kernel uses the standard rustc targets for non-x86 targets, and out > > of those only 64-bit arm's target has kcfi support enabled. For x86, th= e > > custom 64-bit target enables kcfi. > >=20 > > The HAVE_CFI_ICALL_NORMALIZE_INTEGERS_RUSTC config option that allows > > CFI_CLANG to be used in combination with RUST does not check whether th= e > > rustc target supports kcfi. This breaks the build on riscv (and > > presumably 32-bit arm) when CFI_CLANG and RUST are enabled at the same > > time. > >=20 > > Ordinarily, a rustc-option check would be used to detect target support > > but unfortunately rustc-option filters out the target for reasons given > > in commit 46e24a545cdb4 ("rust: kasan/kbuild: fix missing flags on firs= t > > build"). As a result, if the host supports kcfi but the target does not= , > > e.g. when building for riscv on x86_64, the build would remain broken. > >=20 > > Instead, make HAVE_CFI_ICALL_NORMALIZE_INTEGERS_RUSTC depend on the onl= y > > two architectures where the target used supports it to fix the build. >=20 > I'm generally fine with this, but normally we do arch-specific stuff > only in arch/$arch/Kconfig, and expose some kind of > ARCH_HAS_CFI_ICALL_NORMALIZE_INTEGERS that would get tested here. Should > we do that here too? I'm thinking in this case it makes sense to keep this patch simple as it's a fix. Once rustc supports cfi on riscv (which should really just be changing the target to list it as supported), we can reorganize it to match what you're describing at that point. > > CC: stable@vger.kernel.org > > Fixes: ca627e636551e ("rust: cfi: add support for CFI_CLANG with Rust") > > Signed-off-by: Conor Dooley > > --- > > CC: Paul Walmsley > > CC: Palmer Dabbelt > > CC: Alexandre Ghiti > > CC: Miguel Ojeda > > CC: Alex Gaynor > > CC: Boqun Feng > > CC: Gary Guo > > CC: "Bj=C3=B6rn Roy Baron" > > CC: Benno Lossin > > CC: Andreas Hindborg > > CC: Alice Ryhl > > CC: Trevor Gross > > CC: Danilo Krummrich > > CC: Kees Cook > > CC: Sami Tolvanen > > CC: Matthew Maurer > > CC: "Peter Zijlstra (Intel)" > > CC: linux-kernel@vger.kernel.org > > CC: linux-riscv@lists.infradead.org > > CC: rust-for-linux@vger.kernel.org > > --- > > arch/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > >=20 > > diff --git a/arch/Kconfig b/arch/Kconfig > > index d1b4ffd6e0856..880cddff5eda7 100644 > > --- a/arch/Kconfig > > +++ b/arch/Kconfig > > @@ -917,6 +917,7 @@ config HAVE_CFI_ICALL_NORMALIZE_INTEGERS_RUSTC > > def_bool y > > depends on HAVE_CFI_ICALL_NORMALIZE_INTEGERS_CLANG > > depends on RUSTC_VERSION >=3D 107900 > > + depends on ARM64 || X86_64 > > # With GCOV/KASAN we need this fix: https://github.com/rust-lang/rust= /pull/129373 > > depends on (RUSTC_LLVM_VERSION >=3D 190103 && RUSTC_VERSION >=3D 1082= 00) || \ > > (!GCOV_KERNEL && !KASAN_GENERIC && !KASAN_SW_TAGS) > > --=20 > > 2.47.2 > >=20 >=20 > --=20 > Kees Cook