Re: [PATCH v2 2/2] rust: regulator: add devm_enable and devm_enable_optional

[Boqun Feng <boqun.feng@gmail.com>]

On Tue, Sep 09, 2025 at 01:12:51PM -0300, Daniel Almeida wrote:
> 
[...]
> >>> These two functions are already EXPORT_SYMBOL_GPL(), so you won't need
> >>> to add rust_helper for them. Creating rust_helper_*() for them will just
> >>> export additional symbols.
> >> 
> >> These are inlined (stubbed) if CONFIG_REGULATOR is not set, so we need the
> >> helpers to get around that, IIUC.
> >> 
> > 
> > Well, then the question is why we want to compiler regulator.rs if
> > CONFIG_REGULATOR=n? Shouldn't we do:
> 
> Yes, we do want to compile regulator .rs. There´s been prior discussion on
> this (see [0] below, but also [1]).
> 

Thanks for the pointers. Well I guess we really need helper inlining
badly ;-)

Regards,
Boqun

> > 
> > #[cfg(CONFIG_REGULATOR)]
> > pub mod regulator
> > 
> > in rust/kernel/lib.rs?
> 
[...]