From: Brian Norris <briannorris@chromium.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: David Hildenbrand <david@redhat.com>,
linux-kernel@vger.kernel.org, Michal Hocko <mhocko@suse.com>,
Mike Rapoport <rppt@kernel.org>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Suren Baghdasaryan <surenb@google.com>,
Vlastimil Babka <vbabka@suse.cz>,
linux-mm@kvack.org, "Liam R. Howlett" <Liam.Howlett@oracle.com>
Subject: Re: [PATCH] mm: vm_event_item: Explicit #include for THREAD_SIZE
Date: Tue, 9 Sep 2025 17:01:41 -0700 [thread overview]
Message-ID: <aMC_5baavoll9pBM@google.com> (raw)
In-Reply-To: <20250909165336.c9505e477461fd5e41e6cfe4@linux-foundation.org>
On Tue, Sep 09, 2025 at 04:53:36PM -0700, Andrew Morton wrote:
> On Tue, 9 Sep 2025 13:13:57 -0700 Brian Norris <briannorris@chromium.org> wrote:
>
> > This header uses THREAD_SIZE, which is provided by the thread_info.h
> > header but is not included in this header. Depending on the #include
> > ordering in other files, this can produce preprocessor errors.
> >
> > ...
> >
> > --- a/include/linux/vm_event_item.h
> > +++ b/include/linux/vm_event_item.h
> > @@ -2,6 +2,8 @@
> > #ifndef VM_EVENT_ITEM_H_INCLUDED
> > #define VM_EVENT_ITEM_H_INCLUDED
> >
> > +#include <linux/thread_info.h>
> > +
> > #ifdef CONFIG_ZONE_DMA
> > #define DMA_ZONE(xx) xx##_DMA,
> > #else
>
> Is there a known configuraion which triggers this, or was this from
> inspection?
The original trigger was a non-upstream driver that includes this
header. Since the root cause lay here, I figured I might as well patch
it at the origin.
Brian
next prev parent reply other threads:[~2025-09-10 0:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-09 20:13 [PATCH] mm: vm_event_item: Explicit #include for THREAD_SIZE Brian Norris
2025-09-09 23:53 ` Andrew Morton
2025-09-10 0:01 ` Brian Norris [this message]
2025-09-11 12:43 ` Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aMC_5baavoll9pBM@google.com \
--to=briannorris@chromium.org \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=rppt@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.