From: Sean Christopherson <seanjc@google.com>
To: Tom Lendacky <thomas.lendacky@amd.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
x86@kernel.org, linux-crypto@vger.kernel.org,
Paolo Bonzini <pbonzini@redhat.com>,
Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Michael Roth <michael.roth@amd.com>,
Ashish Kalra <ashish.kalra@amd.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
David Miller <davem@davemloft.net>
Subject: Re: [RFC PATCH 3/4] crypto: ccp - Add an API to return the supported SEV-SNP policy bits
Date: Wed, 10 Sep 2025 12:22:12 -0700 [thread overview]
Message-ID: <aMHP5EO-ucJGdHXz@google.com> (raw)
In-Reply-To: <e9014e7dfd7f7c040c5d0eefb1f6c20a3c35d9e5.1755897933.git.thomas.lendacky@amd.com>
On Fri, Aug 22, 2025, Tom Lendacky wrote:
> @@ -1014,6 +1031,7 @@ void *snp_alloc_firmware_page(gfp_t mask);
> void snp_free_firmware_page(void *addr);
> void sev_platform_shutdown(void);
> bool sev_is_snp_ciphertext_hiding_supported(void);
> +u64 sev_get_snp_policy_bits(void);
>
> #else /* !CONFIG_CRYPTO_DEV_SP_PSP */
>
> @@ -1052,6 +1070,8 @@ static inline void sev_platform_shutdown(void) { }
>
> static inline bool sev_is_snp_ciphertext_hiding_supported(void) { return false; }
>
> +static inline u64 sev_get_snp_policy_bits(void) { return 0; }
I don't think you need a stub (the ciphertext hiding one should have been omitted
too). arch/x86/kvm/svm/sev.c depends on CONFIG_KVM_AMD_SEV=y, which in turn
depends on CRYPTO_DEV_SP_PSP=y, so nothing will ever actually need the stub. I
bet the same holds true for the majority of these stubs.
next prev parent reply other threads:[~2025-09-10 19:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-22 21:25 [RFC PATCH 0/4] SEV-SNP guest policy bit support updates Tom Lendacky
2025-08-22 21:25 ` [RFC PATCH 1/4] KVM: SEV: Publish supported SEV-SNP policy bits Tom Lendacky
2025-09-10 19:19 ` Sean Christopherson
2025-09-10 19:36 ` Tom Lendacky
2025-08-22 21:25 ` [RFC PATCH 2/4] KVM: SEV: Consolidate the SEV policy bits in a single header file Tom Lendacky
2025-08-22 21:25 ` [RFC PATCH 3/4] crypto: ccp - Add an API to return the supported SEV-SNP policy bits Tom Lendacky
2025-09-10 19:22 ` Sean Christopherson [this message]
2025-08-22 21:25 ` [RFC PATCH 4/4] KVM: SEV: Add known " Tom Lendacky
2025-09-10 19:23 ` [RFC PATCH 0/4] SEV-SNP guest policy bit support updates Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aMHP5EO-ucJGdHXz@google.com \
--to=seanjc@google.com \
--cc=ashish.kalra@amd.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kvm@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.roth@amd.com \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.