From: Hangbin Liu <liuhangbin@gmail.com>
To: Stanislav Fomichev <stfomichev@gmail.com>
Cc: netdev@vger.kernel.org, Jay Vosburgh <jv@jvosburgh.net>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Sabrina Dubroca <sdubroca@redhat.com>,
Jiri Pirko <jiri@resnulli.us>, Simon Horman <horms@kernel.org>,
Ido Schimmel <idosch@nvidia.com>, Shuah Khan <shuah@kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>,
Kuniyuki Iwashima <kuniyu@google.com>,
Ahmed Zaki <ahmed.zaki@intel.com>,
Alexander Lobakin <aleksander.lobakin@intel.com>,
bridge@lists.linux.dev, linux-kselftest@vger.kernel.org
Subject: Re: [PATCHv3 net-next 3/5] team: use common function to compute the features
Date: Thu, 11 Sep 2025 01:46:55 +0000 [thread overview]
Message-ID: <aMIqAfT__zvr32hM@fedora> (raw)
In-Reply-To: <aMGZwEnJ943Rwf-Q@mini-arch>
On Wed, Sep 10, 2025 at 08:31:12AM -0700, Stanislav Fomichev wrote:
> > @@ -1976,27 +1919,16 @@ static int team_add_slave(struct net_device *dev, struct net_device *port_dev,
> >
> > err = team_port_add(team, port_dev, extack);
> >
> > - if (!err)
> > - netdev_change_features(dev);
> > -
> > return err;
>
> do the same `return team_port_add` here as you do in team_del_slave?
Oh, thanks. I forgot this one.
Hangbin
next prev parent reply other threads:[~2025-09-11 1:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-09 8:18 [PATCHv3 net-next 0/5] net: common feature compute for upper interface Hangbin Liu
2025-09-09 8:18 ` [PATCHv3 net-next 1/5] net: add a common function to compute features from lowers devices Hangbin Liu
2025-09-09 8:18 ` [PATCHv3 net-next 2/5] bonding: use common function to compute the features Hangbin Liu
2025-09-09 8:18 ` [PATCHv3 net-next 3/5] team: " Hangbin Liu
2025-09-10 15:31 ` Stanislav Fomichev
2025-09-11 1:46 ` Hangbin Liu [this message]
2025-09-09 8:18 ` [PATCHv3 net-next 4/5] net: bridge: " Hangbin Liu
2025-09-09 8:18 ` [PATCHv3 net-next 5/5] selftests/net: add offload checking test for virtual interface Hangbin Liu
2025-09-10 14:57 ` Sabrina Dubroca
2025-09-11 6:54 ` Hangbin Liu
2025-09-11 15:41 ` Paolo Abeni
2025-09-12 6:52 ` Hangbin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aMIqAfT__zvr32hM@fedora \
--to=liuhangbin@gmail.com \
--cc=ahmed.zaki@intel.com \
--cc=aleksander.lobakin@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=bridge@lists.linux.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=jiri@resnulli.us \
--cc=jv@jvosburgh.net \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=sdubroca@redhat.com \
--cc=shuah@kernel.org \
--cc=stfomichev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.