From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: rohan.g.thomas@altera.com
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <Jose.Abreu@synopsys.com>,
Rohan G Thomas <rohan.g.thomas@intel.com>,
netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Matthew Gerlach <matthew.gerlach@altera.com>
Subject: Re: [PATCH net 1/2] net: stmmac: est: Fix GCL bounds checks
Date: Thu, 11 Sep 2025 12:24:35 +0100 [thread overview]
Message-ID: <aMKxc6AuEiWplhcV@shell.armlinux.org.uk> (raw)
In-Reply-To: <20250911-qbv-fixes-v1-1-e81e9597cf1f@altera.com>
On Thu, Sep 11, 2025 at 04:22:59PM +0800, Rohan G Thomas via B4 Relay wrote:
> @@ -1012,7 +1012,7 @@ static int tc_taprio_configure(struct stmmac_priv *priv,
> s64 delta_ns = qopt->entries[i].interval;
> u32 gates = qopt->entries[i].gate_mask;
>
> - if (delta_ns > GENMASK(wid, 0))
> + if (delta_ns >= BIT(wid))
While I agree this makes it look better, you don't change the version
below, which makes the code inconsistent. I also don't see anything
wrong with the original comparison.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2025-09-11 11:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-11 8:22 [PATCH net 0/2] net: stmmac: Minor fixes for stmmac EST implementation Rohan G Thomas
2025-09-11 8:22 ` Rohan G Thomas via B4 Relay
2025-09-11 8:22 ` [PATCH net 1/2] net: stmmac: est: Fix GCL bounds checks Rohan G Thomas
2025-09-11 8:22 ` Rohan G Thomas via B4 Relay
2025-09-11 11:24 ` Russell King (Oracle) [this message]
2025-09-11 12:42 ` G Thomas, Rohan
2025-09-12 0:01 ` Jakub Kicinski
2025-09-12 5:04 ` G Thomas, Rohan
2025-09-11 8:23 ` [PATCH net 2/2] net: stmmac: Consider Tx VLAN offload tag length for maxSDU Rohan G Thomas
2025-09-11 8:23 ` Rohan G Thomas via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aMKxc6AuEiWplhcV@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=Jose.Abreu@synopsys.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=matthew.gerlach@altera.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rohan.g.thomas@altera.com \
--cc=rohan.g.thomas@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.