Re: [PATCH v5] tests/functional: add a vfio-user smoke test

[John Levon <john.levon@nutanix.com>]

On Thu, Sep 11, 2025 at 05:27:24PM +0200, Thomas Huth wrote:

> I'm not a python expert, but I guess it would make sense to move that
> description block next to the "class VfioUserClient(QemuSystemTest):" line
> so that it's the description for the class? (that would fix the "Missing
> class docstring" that you get when using "pylint" on your code)

Then pylint complains about the module missing docs, so I think the current
location is a bit better, and I'll add a single line for the class, and made the
file pylint clean generally.

> > +        # wait for libvfio-user to initialize properly
> > +        exec_command_and_wait_for_pattern(self, 'sleep 5', '#', None, server_vm)
> 
> Could the sleep be avoided? ... it's still a race condition (even if it's
> unlikely when you wait for 5 seconds), and always sleeping 5 seconds slows
> down the test quite a bit ...

Currently stress testing a loop that just waits for the socket to appear, so far
so good.

thanks
john