All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Busch <kbusch@kernel.org>
To: Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
	Caleb Sander Mateos <csander@purestorage.com>,
	Keith Busch <kbusch@meta.com>,
	io-uring@vger.kernel.org
Subject: Re: [RFC PATCHv2 1/1] io_uring: add support for IORING_SETUP_SQE_MIXED
Date: Thu, 11 Sep 2025 09:02:11 -0400	[thread overview]
Message-ID: <aMLIU19CfgOAuo8i@kbusch-mbp> (raw)
In-Reply-To: <aMIxmiGv5D0GvSro@fedora>

On Thu, Sep 11, 2025 at 10:19:06AM +0800, Ming Lei wrote:
> On Thu, Sep 11, 2025 at 10:11:47AM +0800, Ming Lei wrote:
> > SQE128 is used for uring_cmd only, so it could be one uring_cmd
> > private flag. However, the implementation may be ugly and fragile.
> 
> Or in case of IORING_SETUP_SQE_MIXED, IORING_OP_URING_CMD is always interpreted
> as plain 64bit SQE, also add IORING_OP_URING_CMD128 for SQE128 only.

Maybe that's good enough, but I was looking for more flexibility to have
big SQEs for read/write too. Not that I have a strong use case for it
now, but in hindsight, that's where "io_uring_attr_pi" should have been
placed instead of outide the submission queue.

  reply	other threads:[~2025-09-11 13:02 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-04 19:27 [RFC PATCHv2 0/1] Keith Busch
2025-09-04 19:27 ` [RFC PATCHv2 1/3] Add support IORING_SETUP_SQE_MIXED Keith Busch
2025-09-11 16:27   ` Caleb Sander Mateos
2025-09-04 19:27 ` [RFC PATCHv2 1/1] io_uring: add support for IORING_SETUP_SQE_MIXED Keith Busch
2025-09-10 17:44   ` Caleb Sander Mateos
2025-09-11  0:28     ` Jens Axboe
2025-09-11  2:11       ` Ming Lei
2025-09-11  2:19         ` Ming Lei
2025-09-11 13:02           ` Keith Busch [this message]
2025-09-11 13:07             ` Ming Lei
2025-09-17 14:44               ` Jens Axboe
2025-09-18 21:22                 ` Keith Busch
2025-09-18 23:35                   ` Jens Axboe
2025-09-11  2:06     ` Keith Busch
2025-09-04 19:27 ` [RFC PATCHv2 2/3] Add nop testing " Keith Busch
2025-09-04 19:27 ` [RFC PATCHv2 3/3] Add mixed sqe test for uring commands Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aMLIU19CfgOAuo8i@kbusch-mbp \
    --to=kbusch@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=csander@purestorage.com \
    --cc=io-uring@vger.kernel.org \
    --cc=kbusch@meta.com \
    --cc=ming.lei@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.