All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org,
	Hanna Czenczek <hreitz@redhat.com>,
	Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>,
	Eric Blake <eblake@redhat.com>
Subject: Re: [PATCH] tests/qemu-iotests: Mark the 'inactive-node-nbd' as unsupported with -luks
Date: Thu, 11 Sep 2025 16:34:22 +0200	[thread overview]
Message-ID: <aMLd7iqM9SBrF33x@redhat.com> (raw)
In-Reply-To: <20250911142922.222365-1-thuth@redhat.com>

Am 11.09.2025 um 16:29 hat Thomas Huth geschrieben:
> From: Thomas Huth <thuth@redhat.com>
> 
> When running "./check -luks inactive-node-nbd", the test currently fails
> because QEMU terminates immediately. The reason can be seen with the
> "-p" parameter of the "check" script:
> 
>  qemu-system-x86_64: -blockdev luks,file=disk-file,node-name=disk-fmt,active=off:
>   Parameter 'key-secret' is required for cipher
> 
> Quoting Kevin: "The test case just isn't made for luks. iotests.py has
> special code for luks in VM.add_drive(), but not in VM.add_blockdev()."
> 
> Thus let's mark it as unsupported on luks to avoid the failure.
> 
> Suggested-by: Kevin Wolf <kwolf@redhat.com>
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Thanks, applied to the block branch.

Kevin



      parent reply	other threads:[~2025-09-11 14:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-11 14:29 [PATCH] tests/qemu-iotests: Mark the 'inactive-node-nbd' as unsupported with -luks Thomas Huth
2025-09-11 14:32 ` Daniel P. Berrangé
2025-09-11 14:34 ` Kevin Wolf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aMLd7iqM9SBrF33x@redhat.com \
    --to=kwolf@redhat.com \
    --cc=eblake@redhat.com \
    --cc=hreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    --cc=vsementsov@yandex-team.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.