From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 69732CAC587 for ; Thu, 11 Sep 2025 14:33:08 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uwiM9-0004PJ-Nx; Thu, 11 Sep 2025 10:33:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uwiM4-0004Ov-TV for qemu-devel@nongnu.org; Thu, 11 Sep 2025 10:32:56 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uwiM3-0002Oa-0J for qemu-devel@nongnu.org; Thu, 11 Sep 2025 10:32:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757601172; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4zlHD+hw9bZeFSshotFEQMeq8W4rwC+MTpPypH1zWqk=; b=HBequqFQvZs9w/reoZJP/30IQyWIMYpxk//XzjrPMtQFkTi3Fn5GzvUvdMiQWTZuV6xJ7x 41U4a2Gt0L0iW6rIjLvoEPEyL5Ao3dzRogxhDJJTkdMbWUWukzEbsyzfmasc7rGXIM6c+x 1HKwKG0B1kqDm/0K9XzNZbLSvM2jzig= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-471-fbaWW6CjOOmCyPzsTZfhkg-1; Thu, 11 Sep 2025 10:32:50 -0400 X-MC-Unique: fbaWW6CjOOmCyPzsTZfhkg-1 X-Mimecast-MFC-AGG-ID: fbaWW6CjOOmCyPzsTZfhkg_1757601170 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0A0411800365; Thu, 11 Sep 2025 14:32:50 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.221]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6CB8C19560B1; Thu, 11 Sep 2025 14:32:47 +0000 (UTC) Date: Thu, 11 Sep 2025 15:32:43 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Thomas Huth Cc: qemu-block@nongnu.org, Kevin Wolf , qemu-devel@nongnu.org, Hanna Czenczek , Vladimir Sementsov-Ogievskiy , Eric Blake Subject: Re: [PATCH] tests/qemu-iotests: Mark the 'inactive-node-nbd' as unsupported with -luks Message-ID: References: <20250911142922.222365-1-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250911142922.222365-1-thuth@redhat.com> User-Agent: Mutt/2.2.14 (2025-02-20) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Thu, Sep 11, 2025 at 04:29:22PM +0200, Thomas Huth wrote: > From: Thomas Huth > > When running "./check -luks inactive-node-nbd", the test currently fails > because QEMU terminates immediately. The reason can be seen with the > "-p" parameter of the "check" script: > > qemu-system-x86_64: -blockdev luks,file=disk-file,node-name=disk-fmt,active=off: > Parameter 'key-secret' is required for cipher > > Quoting Kevin: "The test case just isn't made for luks. iotests.py has > special code for luks in VM.add_drive(), but not in VM.add_blockdev()." > > Thus let's mark it as unsupported on luks to avoid the failure. > > Suggested-by: Kevin Wolf > Signed-off-by: Thomas Huth > --- > tests/qemu-iotests/tests/inactive-node-nbd | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|