Re: [PATCH net-next v2 2/2] net: phylink: warn if deprecated array-style fixed-link binding is used

["Russell King (Oracle)" <linux@armlinux.org.uk>]

On Thu, Sep 11, 2025 at 09:20:48PM +0200, Heiner Kallweit wrote:
> The array-style fixed-link binding has been marked deprecated for more
> than 10 yrs, but still there's a number of users. Print a warning when
> usage of the deprecated binding is detected.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> v2:
> - use %pfw printk specifier
> ---
>  drivers/net/phy/phylink.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
> index 1988b7d20..0524dcc1b 100644
> --- a/drivers/net/phy/phylink.c
> +++ b/drivers/net/phy/phylink.c
> @@ -702,6 +702,9 @@ static int phylink_parse_fixedlink(struct phylink *pl,
>  			return -EINVAL;
>  		}
>  
> +		phylink_warn(pl, "%pfw uses deprecated array-style fixed-link binding!",

\n at the end of a kernel message string is normal.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!