Re: [PATCH 19/33] rust: split "migration" crate

[Zhao Liu <zhao1.liu@intel.com>]

On Mon, Sep 08, 2025 at 12:49:51PM +0200, Paolo Bonzini wrote:
> Date: Mon,  8 Sep 2025 12:49:51 +0200
> From: Paolo Bonzini <pbonzini@redhat.com>
> Subject: [PATCH 19/33] rust: split "migration" crate
> X-Mailer: git-send-email 2.51.0
> 
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> Link: https://lore.kernel.org/r/20250827104147.717203-11-marcandre.lureau@redhat.com
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  MAINTAINERS                                 |  1 +
>  rust/migration/wrapper.h                    | 51 ++++++++++++++++++++
>  rust/qemu-api/wrapper.h                     |  1 -
>  rust/Cargo.lock                             | 12 +++++
>  rust/Cargo.toml                             |  1 +
>  rust/hw/char/pl011/Cargo.toml               |  1 +
>  rust/hw/char/pl011/meson.build              |  1 +
>  rust/hw/char/pl011/src/device.rs            | 13 ++---
>  rust/hw/char/pl011/src/registers.rs         |  2 +-
>  rust/hw/timer/hpet/Cargo.toml               |  1 +
>  rust/hw/timer/hpet/meson.build              |  1 +
>  rust/hw/timer/hpet/src/device.rs            | 11 +++--
>  rust/meson.build                            |  1 +
>  rust/migration/Cargo.toml                   | 21 ++++++++
>  rust/migration/build.rs                     |  1 +
>  rust/migration/meson.build                  | 53 +++++++++++++++++++++
>  rust/migration/src/bindings.rs              | 48 +++++++++++++++++++
>  rust/migration/src/lib.rs                   |  6 +++
>  rust/{qemu-api => migration}/src/vmstate.rs | 42 +++++++++-------
>  rust/qemu-api/Cargo.toml                    |  1 +
>  rust/qemu-api/meson.build                   | 12 ++---
>  rust/qemu-api/src/bindings.rs               | 21 +-------
>  rust/qemu-api/src/cell.rs                   |  4 +-
>  rust/qemu-api/src/lib.rs                    |  1 -
>  rust/qemu-api/src/prelude.rs                |  2 -
>  rust/qemu-api/src/qdev.rs                   |  3 +-
>  rust/qemu-api/src/qom.rs                    |  2 +-
>  rust/qemu-api/tests/tests.rs                |  2 +-
>  rust/qemu-api/tests/vmstate_tests.rs        |  4 +-
>  29 files changed, 252 insertions(+), 68 deletions(-)
>  create mode 100644 rust/migration/wrapper.h
>  create mode 100644 rust/migration/Cargo.toml
>  create mode 120000 rust/migration/build.rs
>  create mode 100644 rust/migration/meson.build
>  create mode 100644 rust/migration/src/bindings.rs
>  create mode 100644 rust/migration/src/lib.rs
>  rename rust/{qemu-api => migration}/src/vmstate.rs (95%)

...

> diff --git a/rust/migration/wrapper.h b/rust/migration/wrapper.h
> new file mode 100644
> index 00000000000..daf316aed41
> --- /dev/null
> +++ b/rust/migration/wrapper.h
> @@ -0,0 +1,51 @@

nit: this file misses SPDX-License-Identifier

> +/*
> + * QEMU System Emulator
> + *
> + * Copyright (c) 2024 Linaro Ltd.
> + *
> + * Authors: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining a copy
> + * of this software and associated documentation files (the "Software"), to deal
> + * in the Software without restriction, including without limitation the rights
> + * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
> + * copies of the Software, and to permit persons to whom the Software is
> + * furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice shall be included in
> + * all copies or substantial portions of the Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
> + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
> + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
> + * THE SOFTWARE.
> + */

Reviewed-by: Zhao Liu <zhao1.liu@intel.com>