From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 893E71A3142 for ; Fri, 12 Sep 2025 08:49:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757666945; cv=none; b=dGS/ObSzZ8d99LXK8dP86aNHTipSvR4EYxCnMu+yl5EDok3MLBIZVnBMz3UWwsvwzIbk8DblUAVFMQIaJI1E1XpfWVuMJD5ogKH8rROCplQtCSuK0OJruzyncTMxeK8wE4WSUR87gdwV2Nai3gQ6hnZjMVjRzLLrKR8YJ3KRHOk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757666945; c=relaxed/simple; bh=VXPyr1y1eVb3aoiXmD/7gslbuD5LlgKzM3CMrgMbH1c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dPb29awgWENIQmQ6tnK0C7jmRR0be6V22OFAhpKOC1K7syC1B+S+5u3ljcN+pfiAPqdhW8i4fSXCedsmizjJTJwGSnBNt/X5WmrMBqRUJKGFiTUhJR7nr6jvy+e26p1r7GoAFq1JUQyMuhQgmHtYlDfZtptN7vFmZDeD8HH/usU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Mp9CRmyS; arc=none smtp.client-ip=209.85.208.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Mp9CRmyS" Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-62ee438dc1bso487552a12.1 for ; Fri, 12 Sep 2025 01:49:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1757666942; x=1758271742; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=ZZvuOQturzsBblI9ZHMQg2RAl3gTfRHzsPsS+SgnjjQ=; b=Mp9CRmySAVvQXCThqurI4OlhnfaG8HiOZGOZpLbp5Jv8MAUpk0OL12UnbgFDnuu7HN X0/r3ksAD+BGu6KUEPEiuQQ2e3BMwPD7IAdUmTcbWdE2CpBATelSXM0tu27B50t/FqMc JoRSmlothzWaYATjhemgdhLF1LysUTZUQom/KZT1BH2IvhGxylihwNu/FIobVHAW90sS /pfP+tqq8pcBfR45BWcHfi6WLTAnUENNmQ2QkFqb+4AjCz5RX198mCD0TG0dJeud6P5t 2mhyXsG+al4hNcAY1imssxHBUlChKNP2IqtO9gHEAWt+G7T1R+H9/Ap2GtvVu8+yNyOj px3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757666942; x=1758271742; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZZvuOQturzsBblI9ZHMQg2RAl3gTfRHzsPsS+SgnjjQ=; b=iT50+v7ffBvpLA3B6gZfMW1z4wrnTolYJQY0f8YudqxRJyo2pVvkSkdybZkvpaMDw7 pHcaJT4qq1Z2W9EKuav66zlIv6LY+gtGyeW6FzEFGq5a7T4NlfLVpluEAr1l1SXvF3L2 LyFJIIu/y8iWBgCfqW2LJbpNPjZ8V1gKbwQZUVPUNN/FmOfy+vkWFI+w/QQZ7Yoht1oa 8y2do6UQ3DP74MAgBN6qh6hrzDEE/piV7RdnkfSgovdKPG3VP2WyFaee9lBcbdrlPzAM ZLWVQI2vcnZ3hwAOlmlIhkaRxDJB2nuD7EFiMgAKd33BnB6tG+w2KminrRdJnxwxBUbf Gy0A== X-Forwarded-Encrypted: i=1; AJvYcCWoTi8uQEoDjS1xmzIrvb/xM3oqO2SeM1YkIPjBX2g/9PL7MTOPy/CXOKUOE0MeO1XtbMsU2pnnTo5HBKgg@vger.kernel.org X-Gm-Message-State: AOJu0YxilnwaU/1aXw8wZU+zTlWnjnI3vDrjYSeUjNp9wMmF/gWG75D/ uTtmY0pfeBMn/E2b58ZWI64tK5YsUVmiV7QlSJ5bWFbf1x+NwnQClJZ+Ei6mMplUzNg= X-Gm-Gg: ASbGncs+BGfcF1L+mwstzb92Qa7hr1jUoJq9LU6aVQxFrsPyPeXUYIlcl+L5d+jTQds Nk/nOca0uaMtjKjyL/ffQIUO6BFC9rFw7jsoCd7OcrXD97bOT81ujt3Sp699C6MtBTTpWuYYcA1 OdFvQsslPGVY25ikLNO5U67cR/eeu9u6O5IjGBFCI3YypOVATxf3hO+XHYb2tubRIJGqGh/kHtj hGxv8ljFOm2p6P1BfKVqi2VcNegCRICoYE4X+DH5+u0QH64JmuSC2EOnN408H9Yp2uSFu3dwnkQ gguG+pmuDta4P1dZsnA0n0uyVf7VE4xySKPLXjdKw3OKxN6uH1VwrcYUuzGFF/mDLZIg7oRjs6W e1e0Ns4k0z3sTrNUACzg879S7sJBUsyo5GD405Q6PNx0oGisGTiDnow== X-Google-Smtp-Source: AGHT+IGIKDkSMzSm94IREaUAgReqwpKS7jzXgP9plHNzao7p19K/88keRhVXdp1JRes2jLYeeNrSFA== X-Received: by 2002:a17:907:3c95:b0:aff:1586:14c2 with SMTP id a640c23a62f3a-b07c22b205dmr282086066b.4.1757666941812; Fri, 12 Sep 2025 01:49:01 -0700 (PDT) Received: from linaro.org ([2a02:2454:ff21:30:5fc2:ee41:2050:2d49]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b07b32f1e54sm324549266b.75.2025.09.12.01.49.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Sep 2025 01:49:01 -0700 (PDT) Date: Fri, 12 Sep 2025 10:48:59 +0200 From: Stephan Gerhold To: Yijie Yang Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio Subject: Re: [PATCH v11 3/4] arm64: dts: qcom: Add HAMOA-IOT-SOM platform Message-ID: References: <20250910-hamoa_initial-v11-0-38ed7f2015f7@oss.qualcomm.com> <20250910-hamoa_initial-v11-3-38ed7f2015f7@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250910-hamoa_initial-v11-3-38ed7f2015f7@oss.qualcomm.com> On Wed, Sep 10, 2025 at 05:02:11PM +0800, Yijie Yang wrote: > The HAMOA-IOT-SOM is a compact computing module that integrates a System > on Chip (SoC) — specifically the x1e80100 — along with essential > components optimized for IoT applications. It is designed to be mounted on > carrier boards, enabling the development of complete embedded systems. > > Make the following peripherals on the SOM enabled: > - Regulators on the SOM > - Reserved memory regions > - PCIe6a and its PHY > - PCIe4 and its PHY > - USB0 through USB6 and their PHYs > - ADSP, CDSP > - Graphic > - Video > > Written in collaboration with Yingying Tang (PCIe4) > and Wangao Wang (Video) > . This looks like you should have Co-developed-by: tags together with their Signed-off-by: tags. > > Reviewed-by: Konrad Dybcio > Signed-off-by: Yijie Yang > --- > arch/arm64/boot/dts/qcom/hamoa-iot-som.dtsi | 621 ++++++++++++++++++++++++++++ > 1 file changed, 621 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/hamoa-iot-som.dtsi b/arch/arm64/boot/dts/qcom/hamoa-iot-som.dtsi > new file mode 100644 > index 000000000000..c7c3a167eb6a > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/hamoa-iot-som.dtsi > @@ -0,0 +1,621 @@ > +// SPDX-License-Identifier: BSD-3-Clause > +/* > + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. > + */ > + > +#include "x1e80100.dtsi" > +#include "x1e80100-pmics.dtsi" > +#include > +#include > + > +/ { > + compatible = "hamoa-iot-som", "qcom,x1e80100"; Undocumented compatible (without "qcom," prefix). I think you can just drop this? Thanks, Stephan