Re: [PATCH 0/4] arm64: dts: qcom: x1e80100: Add IRIS video codec

[Stephan Gerhold <stephan.gerhold@linaro.org>]

On Fri, Sep 12, 2025 at 11:24:21AM +0100, Bryan O'Donoghue wrote:
> On 11/09/2025 19:38, Stephan Gerhold wrote:
> > Add the necessary definitions to enable the IRIS video codec for
> > accelerated video decoding on the X1E CRD and Lenovo ThinkPad T14s. The
> > additions are largely copied as-is from sm8550.dtsi with some minor changes
> > necessary for X1E.
> > 
> > The PAS interface used to boot the IRIS firmware is not functional in EL2.
> > The code to start it without using PAS exists already in the Venus driver,
> > but was not ported over to IRIS yet. Discussions how to model the
> > video-firmware IOMMU are still ongoing, so disable IRIS in x1-el2.dtso for
> > now to avoid regressions when running in EL2.
> > 
> > Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org>
> > ---
> > Stephan Gerhold (4):
> >        arm64: dts: qcom: x1e80100: Add IRIS video codec
> >        arm64: dts: qcom: x1-el2: Disable IRIS for now
> >        arm64: dts: qcom: x1e80100-crd: Enable IRIS video codec
> >        arm64: dts: qcom: x1e78100-lenovo-thinkpad-t14s: Enable IRIS
> > 
> >   arch/arm64/boot/dts/qcom/x1-el2.dtso               |  5 ++
> >   .../dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi    |  5 ++
> >   arch/arm64/boot/dts/qcom/x1e80100-crd.dts          |  4 +
> >   arch/arm64/boot/dts/qcom/x1e80100.dtsi             | 87 ++++++++++++++++++++++
> >   4 files changed, 101 insertions(+)
> > ---
> > base-commit: 8f21d9da46702c4d6951ba60ca8a05f42870fe8f
> > change-id: 20250909-x1e-iris-dt-eb0494a130ca
> > 
> > Best regards,
> > --
> > Stephan Gerhold <stephan.gerhold@linaro.org>
> > 
> > 
> 
> Could you please include the Dell Thena variants in v2 ?
> 

I didn't include that because the firmware-name setup isn't as
straightforward for that as for the T14s. I think all the Thena variants
have existing "firmware-name"s for ADSP though, so I can try to make a
patch that adopts the existing prefix for all the laptops that make use
of x1-dell-thena.dtsi. Or even better would be if you can send me a
tested patch to include. :-)

Thanks,
Stephan