Re: [PATCH 5/8] drm: Pass supported color formats straight onto drm_bridge

[Marius Vlad <marius.vlad@collabora.com>]

[-- Attachment #1: Type: text/plain, Size: 2620 bytes --]

On Fri, Sep 12, 2025 at 05:33:42PM +0200, Maxime Ripard wrote:
> On Thu, Sep 11, 2025 at 04:07:36PM +0300, Marius Vlad wrote:
> > diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c
> > index 61cab32e213a..15820e6ba057 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
> > @@ -1057,7 +1057,7 @@ static int mtk_dpi_bind(struct device *dev, struct device *master, void *data)
> >  	if (ret)
> >  		goto err_cleanup;
> >  
> > -	dpi->connector = drm_bridge_connector_init(drm_dev, &dpi->encoder);
> > +	dpi->connector = drm_bridge_connector_init(drm_dev, &dpi->encoder, BIT(HDMI_COLORSPACE_RGB));
> >  	if (IS_ERR(dpi->connector)) {
> >  		dev_err(dev, "Unable to create bridge connector\n");
> >  		ret = PTR_ERR(dpi->connector);
> > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
> > index d7726091819c..91afdbf676f0 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
> > @@ -930,7 +930,7 @@ static int mtk_dsi_encoder_init(struct drm_device *drm, struct mtk_dsi *dsi)
> >  	if (ret)
> >  		goto err_cleanup_encoder;
> >  
> > -	dsi->connector = drm_bridge_connector_init(drm, &dsi->encoder);
> > +	dsi->connector = drm_bridge_connector_init(drm, &dsi->encoder, BIT(HDMI_COLORSPACE_RGB));
> >  	if (IS_ERR(dsi->connector)) {
> >  		DRM_ERROR("Unable to create bridge connector\n");
> >  		ret = PTR_ERR(dsi->connector);
> > diff --git a/drivers/gpu/drm/meson/meson_encoder_cvbs.c b/drivers/gpu/drm/meson/meson_encoder_cvbs.c
> > index dc374bfc5951..a475fc34ca23 100644
> > --- a/drivers/gpu/drm/meson/meson_encoder_cvbs.c
> > +++ b/drivers/gpu/drm/meson/meson_encoder_cvbs.c
> > @@ -275,7 +275,8 @@ int meson_encoder_cvbs_probe(struct meson_drm *priv)
> >  	}
> >  
> >  	/* Initialize & attach Bridge Connector */
> > -	connector = drm_bridge_connector_init(priv->drm, &meson_encoder_cvbs->encoder);
> > +	connector = drm_bridge_connector_init(priv->drm,
> > +			&meson_encoder_cvbs->encoder, BIT(HDMI_COLORSPACE_RGB));
> >  	if (IS_ERR(connector))
> >  		return dev_err_probe(priv->dev, PTR_ERR(connector),
> >  				     "Unable to create CVBS bridge connector\n");
> 
> Why do we need to pass an HDMI color format for a DSI, DPI or Analog TV
> driver?
That's what drm_bridge_connector_init() had initially set as supported
color format. I just pulled that out for every other driver that made
use of drm_bridge_connector_init. So I guess the answer is we don't
actually need to do that.
> 
> Maxime



[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]