Re: [PATCH] gpiolib: acpi: initialize acpi_gpio_info struct

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Mon, Sep 15, 2025 at 08:46:10AM +0200, Mika Westerberg wrote:
> On Mon, Sep 15, 2025 at 09:30:46AM +0300, Andy Shevchenko wrote:
> > On Mon, Sep 15, 2025 at 06:47:03AM +0200, Mika Westerberg wrote:
> > > On Fri, Sep 12, 2025 at 10:18:50PM +0200, Sébastien Szymanski wrote:
> > > > Since commit 7c010d463372 ("gpiolib: acpi: Make sure we fill struct
> > > > acpi_gpio_info"), uninitialized acpi_gpio_info struct are passed to
> > > > __acpi_find_gpio() and later in the call stack info->quirks is used in
> > > > acpi_populate_gpio_lookup. This breaks the i2c_hid_cpi driver:
> > > > 
> > > > [   58.122916] i2c_hid_acpi i2c-UNIW0001:00: HID over i2c has not been provided an Int IRQ
> > > > [   58.123097] i2c_hid_acpi i2c-UNIW0001:00: probe with driver i2c_hid_acpi failed with error -22
> > > > 
> > > > Fix this by initializing the acpi_gpio_info pass to __acpi_find_gpio()
> > > > 
> > > > Closes: https://bugzilla.kernel.org/show_bug.cgi?id=220388
> > > > Fixes: 7c010d463372 ("gpiolib: acpi: Make sure we fill struct acpi_gpio_info")
> > > > Signed-off-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com>
> > > 
> > > Should have stable tag too, I think. Andy can add that once he applies.
> > 
> > I can add, but this won't appear in the respective mailing list. Or did I miss
> > a new tag for stable?
> 
> It does not need to go to the mailing list. It's enough that it is
> mentioned in the commit. E.g
> 
>   Cc: stable@vger.kernel.org
> 
> And the stable "machinery" will notice it once it hits the mainline.

Fine, I'll add this, thanks!

-- 
With Best Regards,
Andy Shevchenko