From: Patrick Steinhardt <ps@pks.im>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, "SZEDER Gábor" <szeder.dev@gmail.com>
Subject: Re: [PATCH 0/3] ci: don't compile whole project when testing docs with Meson
Date: Mon, 15 Sep 2025 08:04:54 +0200 [thread overview]
Message-ID: <aMeshpRtFWyE0ja4@pks.im> (raw)
In-Reply-To: <xmqqwm64orc1.fsf@gitster.g>
On Thu, Sep 11, 2025 at 10:02:22AM -0700, Junio C Hamano wrote:
> Patrick Steinhardt <ps@pks.im> writes:
>
> > these two patches introduce a new "docs" alias into Meson and use it in
> > our "documentation" CI jobs so that we stop compiling all of Git only to
> > verify the generated manpages. This fixes the issue reported by Gábor in
> > [1].
>
> There are three patches ;-).
Oops, yeah. I added the summary patch close before sending this out :)
> The end-user facing get_option() is called "docs", unlike what the
> "make" side understands, which is "make doc", even though internally
> we call the target internally as "doc_targets" (not "docs_target").
>
> I wonder if we want to let people say "meson compile doc" to match
> the other world?
>
> Will queue. Thanks.
The reason why I picked 'docs' is that the accompanying user-facing
option is also named the same way. It's thus a bit more consistent with
itself to call the target 'docs' as well.
So I slightly lean towards keeping 'docs', but I don't feel too strongly
about it.
Patrick
next prev parent reply other threads:[~2025-09-15 6:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-11 9:16 [PATCH 0/3] ci: don't compile whole project when testing docs with Meson Patrick Steinhardt
2025-09-11 9:16 ` [PATCH 1/3] meson: introduce a "docs" alias to compile documentation only Patrick Steinhardt
2025-09-16 9:14 ` Karthik Nayak
2025-09-16 9:55 ` Patrick Steinhardt
2025-09-16 11:50 ` Karthik Nayak
2025-09-11 9:16 ` [PATCH 2/3] meson: print docs backend as part of the summary Patrick Steinhardt
2025-09-11 9:16 ` [PATCH 3/3] ci: don't compile whole project when testing docs with Meson Patrick Steinhardt
2025-09-16 9:16 ` Karthik Nayak
2025-09-11 17:02 ` [PATCH 0/3] " Junio C Hamano
2025-09-15 6:04 ` Patrick Steinhardt [this message]
2025-09-15 23:13 ` Junio C Hamano
2025-09-16 6:41 ` Patrick Steinhardt
2025-09-16 16:24 ` Junio C Hamano
2025-09-16 9:17 ` Karthik Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aMeshpRtFWyE0ja4@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.