From: Cyril Hrubis <chrubis@suse.cz>
To: Jack Morgan <jmorgan@naotchy.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/2] statmount.h: add check for STATMOUNT_MNT_NS_ID
Date: Mon, 15 Sep 2025 11:15:39 +0200 [thread overview]
Message-ID: <aMfZOzQWQLh82r6y@yuki.lan> (raw)
In-Reply-To: <aMfW_bP12FUgR15H@yuki.lan>
Hi!
> > +/* Enable mnt_ns_id check when system struct statmount is not defined. */
> > +#if !defined(HAVE_STRUCT_STATMOUNT) && !defined(LTP_HAVE_STATMOUNT_MNT_NS_ID)
> > +#define LTP_HAVE_STATMOUNT_MNT_NS_ID 1
> > +#endif
On a second look this looks like you are working around the
fallback definition we have. But there is no configure check for
STATMOUNT_MNT_NS_ID that has to be added to configure.ac, we need
something as:
AC_CHECK_MEMBERS([struct statmount.mnt_ns_id],,,[#include <unistd.h>])
That would define HAVE_STRUCT_STATMOUNT_MNT_NS_ID if that field is
present in the system headers.
And then we can use that with:
#if !defined(HAVE_STRUCT_STATMOUNT) || defined(HAVE_STRUCT_STATMOUNT_MNT_NS_ID)
# define LTP_HAVE_STRUCT_STATMOUNT_MNT_NS_ID 1
#endif
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2025-09-15 9:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-13 0:58 [LTP] [PATCH 1/2] statmount.h: add check for STATMOUNT_MNT_NS_ID Jack Morgan
2025-09-13 0:58 ` [LTP] [PATCH] statmount09.c: Enable mnt_ns_id " Jack Morgan
2025-09-15 9:06 ` [LTP] [PATCH 1/2] statmount.h: add check " Cyril Hrubis
2025-09-15 9:15 ` Cyril Hrubis [this message]
2025-09-17 14:59 ` Jack Morgan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aMfZOzQWQLh82r6y@yuki.lan \
--to=chrubis@suse.cz \
--cc=jmorgan@naotchy.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.