Re: [PATCH 4/6] tests/functional: drop datadrainer class in reverse debugging

["Daniel P. Berrangé" <berrange@redhat.com>]

On Mon, Sep 15, 2025 at 11:18:09AM +0100, Alex Bennée wrote:
> Daniel P. Berrangé <berrange@redhat.com> writes:
> 
> > The reverse debugging test uses the avocado datadrainer class to
> > create a background thread that reads from the console socket and
> > dumps it via python logger.
> >
> > Most tests log console output as a side effect of doing calls
> > to match strings, but this test never tries to match anything.
> >
> > This isn't critical, so just drop the functionality.
> 
> We do end up with zero length logs for all console output although I don't know
> if we got that far before:

AFAICT, the logs were also zero-length with the current code.
When I ran it with the datadrainer code, there didn't seem
to be any output to be drained.  I'm unclear if that's expected
or a sign I did something wrong, or something has broken since
the test was first written ?


> > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> > ---
> >  tests/functional/reverse_debugging.py | 6 ------
> >  1 file changed, 6 deletions(-)
> >
> > diff --git a/tests/functional/reverse_debugging.py b/tests/functional/reverse_debugging.py
> > index 1b880cda8f..9c89f5c897 100644
> > --- a/tests/functional/reverse_debugging.py
> > +++ b/tests/functional/reverse_debugging.py
> > @@ -35,8 +35,6 @@ class ReverseDebugging(LinuxKernelTest):
> >      endian_is_le = True
> >  
> >      def run_vm(self, record, shift, args, replay_path, image_path, port):
> > -        from avocado.utils import datadrainer
> > -
> >          logger = logging.getLogger('replay')
> >          vm = self.get_vm(name='record' if record else 'replay')
> >          vm.set_console()
> > @@ -54,10 +52,6 @@ def run_vm(self, record, shift, args, replay_path, image_path, port):
> >          if args:
> >              vm.add_args(*args)
> >          vm.launch()
> > -        console_drainer = datadrainer.LineLogger(vm.console_socket.fileno(),
> > -                                    logger=self.log.getChild('console'),
> > -                                    stop_check=(lambda : not vm.is_running()))
> > -        console_drainer.start()
> >          return vm
> >  
> >      @staticmethod
> 
> -- 
> Alex Bennée
> Virtualisation Tech Lead @ Linaro
> 

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|