Re: [PATCH v3 09/13] io/channel-socket: rework qio_channel_socket_copy_fds()

["Daniel P. Berrangé" <berrange@redhat.com>]

On Mon, Sep 15, 2025 at 04:22:06PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> We want to switch from qemu_socket_set_block() to newer
> qemu_set_blocking(), which provides return status of operation,
> to handle errors.
> 
> Still, we want to keep qio_channel_socket_readv() interface clean,
> as currently it allocate @fds only on success.
> 
> So, in case of error, we should close all incoming fds and keep
> user's @fds untouched or zero.
> 
> Let's make separate functions qio_channel_handle_fds() and
> qio_channel_cleanup_fds(), to achieve what we want.
> 
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
> ---
>  include/io/channel.h |  8 +++---
>  io/channel-socket.c  | 67 +++++++++++++++++++++++++++++++++-----------
>  2 files changed, 55 insertions(+), 20 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|