From: Raag Jadav <raag.jadav@intel.com>
To: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: intel-xe@lists.freedesktop.org,
Lucas De Marchi <lucas.demarchi@intel.com>,
Lukasz Laguna <lukasz.laguna@intel.com>
Subject: Re: [PATCH 2/2] drm/xe/vf: Don't expose sysfs attributes not applicable for VFs
Date: Mon, 15 Sep 2025 17:18:50 +0200 [thread overview]
Message-ID: <aMguWp_VufXdl5tB@black.igk.intel.com> (raw)
In-Reply-To: <20250915140614.2076-3-michal.wajdeczko@intel.com>
On Mon, Sep 15, 2025 at 04:06:14PM +0200, Michal Wajdeczko wrote:
> VFs can't read BMG_PCIE_CAP(0x138340) register nor access PCODE
> (already guarded by the info.skip_pcode flag) so we shouldn't
> expose attributes that require any of them to avoid errors like:
>
> [] xe 0000:03:00.1: [drm] Tile0: GT0: VF is trying to read an \
> inaccessible register 0x138340+0x0
> [] RIP: 0010:xe_gt_sriov_vf_read32+0x6c2/0x9a0 [xe]
> [] Call Trace:
> [] xe_mmio_read32+0x110/0x280 [xe]
> [] auto_link_downgrade_capable_show+0x2e/0x70 [xe]
> [] dev_attr_show+0x1a/0x70
> [] sysfs_kf_seq_show+0xaa/0x120
> [] kernfs_seq_show+0x41/0x60
>
> Fixes: 0e414bf7ad01 ("drm/xe: Expose PCIe link downgrade attributes")
> Fixes: cdc36b66cd41 ("drm/xe: Expose fan control and voltage regulator version")
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> Cc: Lukasz Laguna <lukasz.laguna@intel.com>
Finally.
Reviewed-by: Raag Jadav <raag.jadav@intel.com>
next prev parent reply other threads:[~2025-09-15 15:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-15 14:06 [PATCH 0/2] drm/xe/sysfs: Fix attributes registration on VFs Michal Wajdeczko
2025-09-15 14:06 ` [PATCH 1/2] drm/xe/sysfs: Simplify and fix sysfs registration Michal Wajdeczko
2025-09-15 15:12 ` Lucas De Marchi
2025-09-15 15:33 ` Michal Wajdeczko
2025-09-16 13:52 ` Lucas De Marchi
2025-09-16 14:56 ` Michal Wajdeczko
2025-09-15 15:17 ` Raag Jadav
2025-09-15 15:51 ` Michal Wajdeczko
2025-09-15 16:03 ` Raag Jadav
2025-09-15 14:06 ` [PATCH 2/2] drm/xe/vf: Don't expose sysfs attributes not applicable for VFs Michal Wajdeczko
2025-09-15 15:18 ` Raag Jadav [this message]
2025-09-15 14:12 ` ✓ CI.KUnit: success for drm/xe/sysfs: Fix attributes registration on VFs Patchwork
2025-09-15 14:51 ` ✓ Xe.CI.BAT: " Patchwork
2025-09-15 17:44 ` ✗ Xe.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aMguWp_VufXdl5tB@black.igk.intel.com \
--to=raag.jadav@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
--cc=lukasz.laguna@intel.com \
--cc=michal.wajdeczko@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.