From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Sutter <phil@nwl.cc>
Cc: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
Subject: Re: [libnftnl RFC] data_reg: Improve data reg value printing
Date: Mon, 15 Sep 2025 23:19:27 +0200 [thread overview]
Message-ID: <aMiC3xCrX_8T8rxe@calendula> (raw)
In-Reply-To: <20250911141503.17828-1-phil@nwl.cc>
Hi Phil,
On Thu, Sep 11, 2025 at 04:11:45PM +0200, Phil Sutter wrote:
> The old code printing each field with data as u32 value is problematic
> in two ways:
>
> A) Field values are printed in host byte order which may not be correct
> and output for identical data will divert between machines of
> different Endianness.
>
> B) The actual data length is not clearly readable from given output.
>
> This patch won't entirely fix for (A) given that data may be in host
> byte order but it solves for the common case of matching against packet
> data.
>
> Fixing for (B) is crucial to see what's happening beneath the bonnet.
> The new output will show exactly what is used e.g. by a cmp expression.
Could you fix this from libnftables? ie. add print functions that have
access to the byteorder, so print can do accordingly.
next prev parent reply other threads:[~2025-09-15 21:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-11 14:11 [libnftnl RFC] data_reg: Improve data reg value printing Phil Sutter
2025-09-11 14:33 ` Florian Westphal
2025-09-11 15:57 ` Phil Sutter
2025-09-15 21:19 ` Pablo Neira Ayuso [this message]
2025-09-15 22:16 ` Phil Sutter
2025-09-16 22:32 ` Pablo Neira Ayuso
2025-09-16 12:08 ` Florian Westphal
2025-09-30 17:14 ` Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aMiC3xCrX_8T8rxe@calendula \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.