From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 737D1CAC592 for ; Tue, 16 Sep 2025 20:08:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Type:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To :Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uea5mfPfz6gsP2PTuhVLwd3VedG7XAMEGNBdCWZOsHw=; b=0yAbVnVZDOn02q6CEn/L/nk5Z3 dCRhV+peF3jDCgfYuf4VdiPeDly0tD9xk6pQsFp/EaRp/lSfwzN+zDAmzi5TBr7N9Fjp2jKXuXUZW tqEwBPXRro8w4/6bBC2GgTZdoFIdKMU1HcyCovshBWZwLyNw98nhRQjGT3P0kD0KTybRpGiwNHSMt JN5VqfTcp3eLjPCIBQS/Ts0GvQlMS+Xdc70iNDsrf15TCq0zoEi63OA6qHcLzoAxDlCKUVDVJiIww WCvN0CPsEWDfxhvYeDB9U9LH7jPSDEH3a2K3kqUUfPS93ooJwd1Cv7c/gWKmnlssz6+tPksLFla9p ZgnDvfOQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uybyi-00000008xeh-313J; Tue, 16 Sep 2025 20:08:40 +0000 Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uyTkc-00000007eh7-2GtM for kexec@lists.infradead.org; Tue, 16 Sep 2025 11:21:35 +0000 Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-61feb87fe26so6301405a12.1 for ; Tue, 16 Sep 2025 04:21:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1758021693; x=1758626493; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=uea5mfPfz6gsP2PTuhVLwd3VedG7XAMEGNBdCWZOsHw=; b=UA4nu9qOruySP7Me/jc/2uaOrZg/GdBPfGBZUwwsjnY1cdOlpMErAPhYUqLTZCF+I4 dEL3zvrTHIzPG9cUyupNymjerADZSgAgk0cx+lc+pN/hZwe6mNwOzBrO0tXvUN7Qjw8t WtTxCrZ0YFZY39XOrPBWWXvXYqQsg8xUjxx3Dl1o9Ts6cN+8F9GwzoCvH7u1cxi1M2rJ 3Def04SdEgJ1Kjtx3Jiv/QudMwSI+UMK6HDqlUYoxEHbGUJ9m/0dbOop7Q5f3Oe8pb4G QEkKPh09lAi9TkAUskYmyCksfs6jIg5LXJxbY6rNQotHk5ILcoqKrsnQdyyXDpUAIdYN iDhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758021693; x=1758626493; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=uea5mfPfz6gsP2PTuhVLwd3VedG7XAMEGNBdCWZOsHw=; b=b2Jm4i+fiV/RWXSHja6d6wXIPQ4hwfywM1j6CqZY/9GP5dHZ69MyqqR2AGp6JojguY BOqNAq5cvguYNgVjO4MkwgVnPm86JkuiwtPp2eI4WlyRxMJETI6hoH+9KmBiM7rK2Mbp nvPdjVGtxuOZKoSQzLhwgSXrHbCBCtLxhsdW+UnkWQPzfdDqQK84vn3pKvFnynsyoMy0 BPo1YBYabHmVqefvHipfvPFbDDDFqDrjEB0i0vQLCoBvYletP9gB3NU97su42uhsXzyo a1EI/hg8frQSxwQ4hhlbQm6JXg5XwjjC/kXHKHuQflK2+0YT5wVJasApQO7bsVh73nNS FU4Q== X-Forwarded-Encrypted: i=1; AJvYcCUBGoP6RvpXnk4dvRAc391HbuenN800F9q5BZhGm+ODZ8cUhieC+MlIpE/0tEZREb/fWPqN0w==@lists.infradead.org X-Gm-Message-State: AOJu0YzO9Qii68OjhJW7/5W0ZSNvffMoa2qH+hdUib5s8iGmWwN5W2kw Xiws7tDdFBBQubpGFycAq/9llKPAJGiBNeOptqhDEjJ/KAqpok4W2LQ0wFftCapr5uc= X-Gm-Gg: ASbGncs2TVLSvZoRiUgJ9cKd7/+L1JE0lNm2vubcanrVX2S5T/y4s3TZKyvY+0sz2MC BQqBqNBVxWr4Esu1BIWRACOxiV07p8EbngUamh17g7nyl/PT+WlNO82PGJ3qYe+bgnqU/Kdm30X 1OFy6jb6VXJk0njKNG/dPlH6j8FFEjRY9tYuc5DV9yDs3s6+ecVZ6Fkt6w1xh8CkocGt/O0m67N NJUmiIMLES7zIlf2H5qBLfazv3RCyLxndQnHnThfwqvHqDU8Y5115weBrljts3Rxa0JxUzwzkWk i7joXkacIeNNzbDLi109yiXfdnhm7vH0jrUl22c3A8ik/tf8TQ5K9y5h1MGw0q8gjINY5afeTtM MQPfXCu3raJddD2LbDWxgxvX/T15svv3ctevFEa7+ X-Google-Smtp-Source: AGHT+IGdaApH84qgSh4FpIAmIv68lRlYszt1DGU1HPMtQq+Jg7ayFfDUxA0h2cZACJ5agdILmluAcw== X-Received: by 2002:a17:907:6d22:b0:b0c:5929:4cff with SMTP id a640c23a62f3a-b0c59295025mr1006070266b.26.1758021692577; Tue, 16 Sep 2025 04:21:32 -0700 (PDT) Received: from pathway.suse.cz (nat2.prg.suse.com. [195.250.132.146]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b07b32f21a2sm1156991066b.83.2025.09.16.04.21.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Sep 2025 04:21:32 -0700 (PDT) Date: Tue, 16 Sep 2025 13:21:30 +0200 From: Petr Mladek To: Jinchao Wang Subject: Re: [PATCH v2 6/9] printk/nbcon: use panic_on_this_cpu() helper Message-ID: References: <20250825022947.1596226-1-wangjinchao600@gmail.com> <20250825022947.1596226-7-wangjinchao600@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250825022947.1596226-7-wangjinchao600@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250916_042134_593328_4F244B27 X-CRM114-Status: UNSURE ( 9.93 ) X-CRM114-Notice: Please train this message. X-Mailman-Approved-At: Tue, 16 Sep 2025 13:07:58 -0700 X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sravan Kumar Gundu , linux-fbdev@vger.kernel.org, Kees Cook , "Darrick J. Wong" , Yunhui Cui , Yicong Yang , Zsolt Kajtar , linux-hardening@vger.kernel.org, Ingo Molnar , Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , Simona Vetter , Max Kellermann , John Ogness , Baoquan He , Sergey Senozhatsky , Helge Deller , Joel Granados , Thorsten Blum , Jason Gunthorpe , Dave Young , Vivek Goyal , Nam Cao , Qianqiang Liu , Yury Norov , Steven Rostedt , dri-devel@lists.freedesktop.org, Jonathan Cameron , Sohil Mehta , Thomas Gleixner , Luo Gengkun , Feng Tang , Shixiong Ou , Anna Schumaker , Tony Luck , Joel Fernandes , kexec@lists.infradead.org, Douglas Anderson , Li Huafei , linux-kernel@vger.kernel.org, Thomas Zimmermann , Tejun Heo , Andrew Morton Sender: "kexec" Errors-To: kexec-bounces+kexec=archiver.kernel.org@lists.infradead.org On Mon 2025-08-25 10:29:34, Jinchao Wang wrote: > nbcon_context_try_acquire() compared panic_cpu directly with > smp_processor_id(). This open-coded check is now provided by > panic_on_this_cpu(). > > Switch to panic_on_this_cpu() to simplify the code and improve readability. > > Signed-off-by: Jinchao Wang It looks good to me: Reviewed-by: Petr Mladek Best Regards, Petr From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FC162C15A2 for ; Tue, 16 Sep 2025 11:21:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758021696; cv=none; b=fZz9Dp81u6E/YokHa0y4xPVYG2YLpA0pDosFHWIMbBg3JNUfaCxKVVbXwx7MHKdoRs478dr2Dls5sfs43fReFeMmwrzKhagwFQAx326OrDPnIn/cyzUy/KF4r6lhtKxXRMEtQirnCehzh/8YTSHJGxtBN0bfg5+cI7+SnZ+4cbE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758021696; c=relaxed/simple; bh=PT6RSjPR6nsTnNS42majHjNEe7o+uTu6M+72v8l3iSc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rYKqWE5LhhAD02h8lk48ZGkAJ5BhJi87EAz4z4nJBO9zYpjk4dsAoP1WoZiimhAQPc7L77PCLuP4IUejb5CrGS49+y5WB//0JMr9vh74ghqSd4MDBo7QRN77Zr5tXr5MgTsQav2HRQ9WaDKbODIZFrWFbufwonWdDZS62yOeS/k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=ggSv8Srp; arc=none smtp.client-ip=209.85.208.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="ggSv8Srp" Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-62105d21297so10341754a12.0 for ; Tue, 16 Sep 2025 04:21:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1758021693; x=1758626493; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=uea5mfPfz6gsP2PTuhVLwd3VedG7XAMEGNBdCWZOsHw=; b=ggSv8SrpUu3/G6YUa1wCB3eOnf6vlEV4WeAX8168zTXT1c5RrkysFb61x/IVrZ2ioB ksyyTs+pgvPE4v66yYHmsbhT6Sxfdc1/foredqRYf5rN2sLyqg+cjFpSL3lFP5QwrThR sH88ZjERmT9cJp+uPskNrTd5fJhxe5ChuHeJBqmGGytfpCfeHYAoBj2z/d5gMcePUxkl OYNAxJO+u3Xe+yz4IuafMXvwLdPaT0FB6HMVuHUcmtY5Vy5V5R7bPexqmPPu9Zmaozrd DHWcJ+rZfSxQtX8rvX0pPWk/uLtGYPvyuCp5+OGndrFzBgkWiBbkLSNncnh/la0oseLx DuUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758021693; x=1758626493; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=uea5mfPfz6gsP2PTuhVLwd3VedG7XAMEGNBdCWZOsHw=; b=cBwTb3Qq5sojw0nKSbYRxe0HAAhhMqYZldKDqHLOJp5LCq5za3+zW14Qov0pJbGbLk nWax8mXd2WKrw+6kyF/euT+UkT9kb037PfJAktrqEzQwMFZJq7MZnZAlHXcMtmBqa+VC ZVFewRvITl2N/Gys48vR9Gm2DuqtA4RPfXRILjFqErswHNFq/AXb8SC3LXMq/wvf8XI6 +XdVYN9QJ3OHM5eiYkNZx8BM6vuDbSJd3kW5/80FmrCgj9eJmwpheipu0IY15tWV8lwD EXKPyBzyFLcttIekWzdAI6Klq/dARVOOT+Fsh5cwMy5BQe4XnPDLqTdJZ5JnsKZnL/Gh cG+w== X-Forwarded-Encrypted: i=1; AJvYcCWZihnxwlSt7nDAVPPb7yj7utiln7j4go9RCAvszcQX+ZVuJeoPhOqr50jh4bJu2pSTvDsZIQHB3m6xYQ==@vger.kernel.org X-Gm-Message-State: AOJu0YylQ2QYG9+0uFnRGtZ7XbvPSS17nbJwTS9OO5jBwKc0iZDdHwrZ reOBpXQ3givfZQaLekQWJkBvTNe5Tmnvyq4HzgijJSilKWNdYX4MdqtrTDhaDyP6gLo= X-Gm-Gg: ASbGncuUqDvbEnSJWnV9oXQYzBr3aTIM+fTc0jb9r3Y8EjyuGyWISnDCQHs4YguK0b3 XkuWf5vhLmr83Enjl8y6UyoT2sTEUYwTID0wa3ik0kW0x1McznLIgKyIlAPoUCSi5Xu2vnsIEBF wZqx6j4jjeXELjJ0dy2apEHK1Is2AvYQeag1UB1avR6wEqDcHY4JDYS857BKMt9NqGLosV+IWBN PX0DGecNV+/MdfblfhO6+F+I9vlWgUA7aGS1ytVNFR9GQ0BnUwsUtt7FjQiEQIm2PPY17hvSGEu eWZuj4ktoFxK7/wfaL5Uf+VpYPLV5a9d3mhafpJdU3JX8lsUmj1f3984yYERPKO4vME8dDnVRx5 h9H/EpeM8ZoZ8GDlVmeuwacgVBlx+kIewQoYA5LR4 X-Google-Smtp-Source: AGHT+IGdaApH84qgSh4FpIAmIv68lRlYszt1DGU1HPMtQq+Jg7ayFfDUxA0h2cZACJ5agdILmluAcw== X-Received: by 2002:a17:907:6d22:b0:b0c:5929:4cff with SMTP id a640c23a62f3a-b0c59295025mr1006070266b.26.1758021692577; Tue, 16 Sep 2025 04:21:32 -0700 (PDT) Received: from pathway.suse.cz (nat2.prg.suse.com. [195.250.132.146]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b07b32f21a2sm1156991066b.83.2025.09.16.04.21.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Sep 2025 04:21:32 -0700 (PDT) Date: Tue, 16 Sep 2025 13:21:30 +0200 From: Petr Mladek To: Jinchao Wang Cc: Andrew Morton , Baoquan He , Yury Norov , Qianqiang Liu , Simona Vetter , Helge Deller , Steven Rostedt , John Ogness , Sergey Senozhatsky , Vivek Goyal , Dave Young , Kees Cook , Tony Luck , "Guilherme G. Piccoli" , Thomas Zimmermann , Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , Shixiong Ou , Zsolt Kajtar , Ingo Molnar , Nam Cao , Jonathan Cameron , Joel Fernandes , Joel Granados , Jason Gunthorpe , Sohil Mehta , Feng Tang , Sravan Kumar Gundu , Douglas Anderson , Thomas Gleixner , Anna Schumaker , "Darrick J. Wong" , Max Kellermann , Yunhui Cui , Tejun Heo , Luo Gengkun , Li Huafei , Thorsten Blum , Yicong Yang , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, kexec@lists.infradead.org, linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 6/9] printk/nbcon: use panic_on_this_cpu() helper Message-ID: References: <20250825022947.1596226-1-wangjinchao600@gmail.com> <20250825022947.1596226-7-wangjinchao600@gmail.com> Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250825022947.1596226-7-wangjinchao600@gmail.com> On Mon 2025-08-25 10:29:34, Jinchao Wang wrote: > nbcon_context_try_acquire() compared panic_cpu directly with > smp_processor_id(). This open-coded check is now provided by > panic_on_this_cpu(). > > Switch to panic_on_this_cpu() to simplify the code and improve readability. > > Signed-off-by: Jinchao Wang It looks good to me: Reviewed-by: Petr Mladek Best Regards, Petr