From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44E37306B15 for ; Tue, 16 Sep 2025 11:57:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758023826; cv=none; b=YShSYctIwPzNKm9YCna55LzKfRa2DkQq4eWBRuDhCDfjDz9b4E0Ys3YUWAPzL9BOxboFkf7plZln/mxDjLB7RyvVGGUfz7AkptgaqCAFueJFGz/PQJNHhT700rYDgOyBN2svLCsNUIdBVQ7BLJ+T6KmRpJ4KbGNN8cmDYaEgCuw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758023826; c=relaxed/simple; bh=DhwkCUF4dudkXP7+wY51z+786KhHrdUbmAB0Gd0fdow=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Gf0+FFfyNVV3MAJWEylHL5vX9/7W+oQ0/UlypkU/+rLWhxFXh9IJYbJWXSyn1LqqbVnFfnvRYINWab2Adq8xlo7NxCBbg4TT2UNRu6NJzc1ELYxO/4kphfSI6f+mwOh2x0TN0fmIqy57xca5Mz/bfo4gMrlPWXb/iMGZvmKEOlo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=KPiZdEaE; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="KPiZdEaE" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-45f30011eceso46245e9.1 for ; Tue, 16 Sep 2025 04:57:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1758023822; x=1758628622; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ySSczih2oIxRE/mCuJE87rsnZpN4MGD71PRCDCNKi2s=; b=KPiZdEaEeJdPYZa22vWeG+EE6ZaBx1YSo1SWuc3NacYwuaXznV/VnzOucCyqQAaNAU yb3SBfqzBGP2kP8lGCwKras/YBgPucSr11frXakLdDzJMWASebQf0oX44goG5n76h4Xv bnEdp18Rjloupl+4NjQ11IOqF4SGXiSZew3Cu2Ixab409Bk5lDX3n21CWTX5Q6QFLmWG 7Yg91UhwnskfQfYNEaf9Erh3EMC6qrgTPpn+H16srsqoDLsPcsI/+HUIE+De6Xre5oaf jWSbScNvmOmUf3/vuAJnny1L9jewUY/8N1lz47dzP6+pl4ZuKA5+LPwsj5fUWO6y13Sn nr6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758023822; x=1758628622; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ySSczih2oIxRE/mCuJE87rsnZpN4MGD71PRCDCNKi2s=; b=RHLgNrOgok8hViJzLtSMxmIpZ6f3awJpDqmSgk0facZDP7pTmXtECJ2d9K2uAODjXn sQI6W1gYKqQZZPIzxzizPsts+zD7kMPGlarRUoiKXMvy0SunPAcJgK8b8EstyPvrPtMf XVG1L2AoMzqFN5NPjFm3V+p3UzNNgOum9qYy8WulpU6RTSP3dCqdS32Gme2Ow7rvEiuy P6hvZuuQIr9ySs/mOBfrKLvzf/D/kMEm5Y3LgF7dE7kBku+DJutydT0LAwM7+BZPDPpe zR90T5AhgYVvYBxzr9Z/sMD2KnQt5pGRu5sAINOT1ShEDlgCg4rwwgBDBHlSwVZhaRdR W6Cw== X-Forwarded-Encrypted: i=1; AJvYcCVrSMFs2l25Ez2y/nHGPBpxaF9vdzb/h7KwI9Owp80xO5NP0kD21PMqY9IPdwr6ZMYB7tW6V4c=@lists.linux.dev X-Gm-Message-State: AOJu0YxwOgsZvRFylLgGJjX09w5SOUGavZO8Htskn667K6YZLNEPD0vP WpSkodiJO5ng9t/HDbPj9IZoufvCDUlNmcX5vhdJ2JyI8/KYcZ5VFLWmxOs7Eu0wRA== X-Gm-Gg: ASbGncshz/AloEh35jGL3S7D1no8wTXGBRYGMSZDXN8le92ouyNVLoAC74nVDUg2h2T axI46mFjT8+hibCHqKYKGjKxHYmcCEAuShM6Gc3gUw79auZmHm0YLnWw847BRlnMj0AVysy70ZY iaJ+QuRn0P12aLOAio5BMDBbAosRg1v1xE/WqgPd9CHHPYbUWK5UP2sZ2pQ+8B7NtG1JcupfrxO 8VhFhER//4pqEy8LA8v8v4NpKxmvjLgIIfcmP0uzZggWuL89yKNI2nleNAzjBptpPfxwu8oNd3Q FLf/Cdw82xwYHs19jwCtEE+S210cM4PXOY0l8vbLJwFg+uLBqo6W7bmgMXzSC/qbcvb6LoxyWl3 DKbcwTX5KjNuz6HBdxa+PQXeLV2RLjui+cs3CX39TjOvu7TT+7XuI6P5FmKoMw0VQg1To4Q== X-Google-Smtp-Source: AGHT+IHVAA1mnayi87cRkdBzWdXwnComM1Vq5NxdtVwd631wdxx6byWBLXjdkxRQfsfT6Te7gJR0sQ== X-Received: by 2002:a05:600c:4689:b0:43d:409c:6142 with SMTP id 5b1f17b1804b1-45f320079e2mr1709505e9.0.1758023822383; Tue, 16 Sep 2025 04:57:02 -0700 (PDT) Received: from google.com (157.24.148.146.bc.googleusercontent.com. [146.148.24.157]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45f3260a1ddsm15806845e9.5.2025.09.16.04.57.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Sep 2025 04:57:01 -0700 (PDT) Date: Tue, 16 Sep 2025 11:56:58 +0000 From: Mostafa Saleh To: Will Deacon Cc: linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, maz@kernel.org, oliver.upton@linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, robin.murphy@arm.com, jean-philippe@linaro.org, qperret@google.com, tabba@google.com, jgg@ziepe.ca, mark.rutland@arm.com, praan@google.com Subject: Re: [PATCH v4 01/28] KVM: arm64: Add a new function to donate memory with prot Message-ID: References: <20250819215156.2494305-1-smostafa@google.com> <20250819215156.2494305-2-smostafa@google.com> Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Sep 09, 2025 at 02:46:42PM +0100, Will Deacon wrote: > On Tue, Aug 19, 2025 at 09:51:29PM +0000, Mostafa Saleh wrote: > > Soon, IOMMU drivers running in the hypervisor might interact with > > non-coherent devices, so it needs a mechanism to map memory as > > non cacheable. > > Add ___pkvm_host_donate_hyp() which accepts a new argument for prot, > > so the driver can add KVM_PGTABLE_PROT_NORMAL_NC. > > > > Signed-off-by: Mostafa Saleh > > --- > > arch/arm64/kvm/hyp/include/nvhe/mem_protect.h | 1 + > > arch/arm64/kvm/hyp/nvhe/mem_protect.c | 11 +++++++++-- > > 2 files changed, 10 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm64/kvm/hyp/include/nvhe/mem_protect.h b/arch/arm64/kvm/hyp/include/nvhe/mem_protect.h > > index 5f9d56754e39..52d7ee91e18c 100644 > > --- a/arch/arm64/kvm/hyp/include/nvhe/mem_protect.h > > +++ b/arch/arm64/kvm/hyp/include/nvhe/mem_protect.h > > @@ -36,6 +36,7 @@ int __pkvm_prot_finalize(void); > > int __pkvm_host_share_hyp(u64 pfn); > > int __pkvm_host_unshare_hyp(u64 pfn); > > int __pkvm_host_donate_hyp(u64 pfn, u64 nr_pages); > > +int ___pkvm_host_donate_hyp(u64 pfn, u64 nr_pages, enum kvm_pgtable_prot prot); > > int __pkvm_hyp_donate_host(u64 pfn, u64 nr_pages); > > int __pkvm_host_share_ffa(u64 pfn, u64 nr_pages); > > int __pkvm_host_unshare_ffa(u64 pfn, u64 nr_pages); > > diff --git a/arch/arm64/kvm/hyp/nvhe/mem_protect.c b/arch/arm64/kvm/hyp/nvhe/mem_protect.c > > index 8957734d6183..861e448183fd 100644 > > --- a/arch/arm64/kvm/hyp/nvhe/mem_protect.c > > +++ b/arch/arm64/kvm/hyp/nvhe/mem_protect.c > > @@ -769,13 +769,15 @@ int __pkvm_host_unshare_hyp(u64 pfn) > > return ret; > > } > > > > -int __pkvm_host_donate_hyp(u64 pfn, u64 nr_pages) > > +int ___pkvm_host_donate_hyp(u64 pfn, u64 nr_pages, enum kvm_pgtable_prot prot) > > { > > u64 phys = hyp_pfn_to_phys(pfn); > > u64 size = PAGE_SIZE * nr_pages; > > void *virt = __hyp_va(phys); > > int ret; > > > > + WARN_ON(prot & KVM_PGTABLE_PROT_X); > > Should this actually just enforce that the permissions are > KVM_PGTABLE_PROT_RW: > > WARN_ON((prot & KVM_PGTABLE_PROT_RWX) != KVM_PGTABLE_PROT_RW); > > ? > > Since the motivation is about the memory type rather than the > permissions, it would be best to preserve the current behaviour. Yes, this series doesn't do any permisson changes, I was not sure if that would be needed in the future or not (some RO mappings), but I will update the check as suggested to be more strict. Thanks, Mostafa > > Will