From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: Christian Brauner <brauner@kernel.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev, Jan Kara <jack@suse.cz>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <nick.desaulniers+lkml@gmail.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>
Subject: Re: [PATCH v1 1/1] lock_mount(): Remove unused function
Date: Tue, 16 Sep 2025 15:37:47 +0300 [thread overview]
Message-ID: <aMlaG5gXag1C-MGr@smile.fi.intel.com> (raw)
In-Reply-To: <aMlHXBswxpy0D7s9@smile.fi.intel.com>
On Tue, Sep 16, 2025 at 02:17:48PM +0300, Andy Shevchenko wrote:
> On Tue, Sep 16, 2025 at 02:25:37AM +0100, Al Viro wrote:
> > On Mon, Sep 15, 2025 at 06:02:21PM +0200, Andy Shevchenko wrote:
> > > clang is not happy about unused function:
> > >
> > > /fs/namespace.c:2856:20: error: unused function 'lock_mount' [-Werror,-Wunused-function]
> > > 2856 | static inline void lock_mount(const struct path *path,
> > > | ^~~~~~~~~~
> > > 1 error generated.
> > >
> > > Fix the compilation breakage (`make W=1` build) by removing unused function.
> > >
> > > Fixes: d14b32629541 ("change calling conventions for lock_mount() et.al.")
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> >
> > Folded into commit in question to avoid bisect hazard
>
> Thank you!
It seems similar treatment needs for node_to_mnt_ns() as it's now unused after
the commit 96ff702edaec ("mnt: support ns lookup") if I'm not mistaken.
Should I send a patch?
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2025-09-16 12:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-15 16:02 [PATCH v1 1/1] lock_mount(): Remove unused function Andy Shevchenko
2025-09-16 1:25 ` Al Viro
2025-09-16 11:17 ` Andy Shevchenko
2025-09-16 12:37 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aMlaG5gXag1C-MGr@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=justinstitt@google.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.