From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>,
Richard Cochran <richardcochran@gmail.com>
Subject: Re: [PATCH net-next 1/5] net: dsa: mv88e6xxx: rename TAI definitions according to core
Date: Tue, 16 Sep 2025 14:36:00 +0100 [thread overview]
Message-ID: <aMlnwFGS-uBbBzRF@shell.armlinux.org.uk> (raw)
In-Reply-To: <20250916084645.gy3zdejdsl54xoet@skbuf>
On Tue, Sep 16, 2025 at 11:46:45AM +0300, Vladimir Oltean wrote:
> On Mon, Sep 15, 2025 at 02:06:15PM +0100, Russell King (Oracle) wrote:
> > /* Offset 0x09: Event Status */
> > -#define MV88E6XXX_TAI_EVENT_STATUS 0x09
> > -#define MV88E6XXX_TAI_EVENT_STATUS_ERROR 0x0200
> > -#define MV88E6XXX_TAI_EVENT_STATUS_VALID 0x0100
> > -#define MV88E6XXX_TAI_EVENT_STATUS_CTR_MASK 0x00ff
> > -
> > /* Offset 0x0A/0x0B: Event Time */
>
> Was it intentional to keep the comment for a register with removed
> definitions, and this placement for it? It looks like this (confusing
> to me):
>
> /* Offset 0x09: Event Status */
> /* Offset 0x0A/0x0B: Event Time */
> #define MV88E6352_TAI_EVENT_STATUS 0x09
Yes, totally intentional.
All three registers are read by the code - as a single block, rather
than individually. While the definitions for the event time are not
referenced, I wanted to keep their comment, and that seemed to be
the most logical way.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2025-09-16 13:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-15 13:05 [PATCH net-next 0/5] net: dsa: mv88e6xxx: further PTP-related cleanups Russell King (Oracle)
2025-09-15 13:06 ` [PATCH net-next 1/5] net: dsa: mv88e6xxx: rename TAI definitions according to core Russell King (Oracle)
2025-09-16 8:46 ` Vladimir Oltean
2025-09-16 13:36 ` Russell King (Oracle) [this message]
2025-09-16 14:35 ` Vladimir Oltean
2025-09-16 16:14 ` Russell King (Oracle)
2025-09-15 13:06 ` [PATCH net-next 2/5] net: dsa: mv88e6xxx: remove unused TAI definitions Russell King (Oracle)
2025-09-16 9:23 ` Vladimir Oltean
2025-09-15 13:06 ` [PATCH net-next 3/5] net: dsa: mv88e6xxx: remove duplicated register definition Russell King (Oracle)
2025-09-16 9:22 ` Vladimir Oltean
2025-09-15 13:06 ` [PATCH net-next 4/5] net: dsa: mv88e6xxx: remove unused 88E6165 register definitions Russell King (Oracle)
2025-09-15 13:06 ` [PATCH net-next 5/5] net: dsa: mv88e6xxx: move mv88e6xxx_hwtstamp_work() prototype Russell King (Oracle)
2025-09-16 8:09 ` Vladimir Oltean
2025-09-16 8:36 ` Russell King (Oracle)
2025-09-16 9:03 ` Vladimir Oltean
2025-09-16 12:46 ` Andrew Lunn
2025-09-16 15:31 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aMlnwFGS-uBbBzRF@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.