All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Leo Yan <leo.yan@arm.com>, Jiri Olsa <jolsa@kernel.org>,
	Ian Rogers <irogers@google.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
	Tamas Zsoldos <tamas.zsoldos@arm.com>
Subject: Re: [PATCH] perf session: Fix handling when buffer exceeds 2 GiB
Date: Wed, 17 Sep 2025 14:41:50 -0300	[thread overview]
Message-ID: <aMry3oh_qaV0ZI03@x1> (raw)
In-Reply-To: <aJ-V2ZsYpN8RDQ3M@google.com>

On Fri, Aug 15, 2025 at 01:17:29PM -0700, Namhyung Kim wrote:
> On Fri, Aug 08, 2025 at 02:24:40PM +0100, Leo Yan wrote:
> > If a user specifies an AUX buffer larger than 2 GiB, the returned size
> > may exceed 0x80000000. Since the err variable is defined as a signed
> > 32-bit integer, such a value overflows and becomes negative.
> > 
> > As a result, the perf record command reports an error:
> > 
> >   0x146e8 [0x30]: failed to process type: 71 [Unknown error 183711232]
> > 
> > Change the type of the err variable to a signed 64-bit integer to
> > accommodate large buffer sizes correctly.
> > 
> > Reported-by: Tamas Zsoldos <tamas.zsoldos@arm.com>
> > Fixes: d5652d865ea7 ("perf session: Add ability to skip 4GiB or more")
> > Signed-off-by: Leo Yan <leo.yan@arm.com>
> 
> Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks, applied to perf-tools-next,

- Arnaldo

      reply	other threads:[~2025-09-17 17:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-08 13:24 [PATCH] perf session: Fix handling when buffer exceeds 2 GiB Leo Yan
2025-08-15 20:17 ` Namhyung Kim
2025-09-17 17:41   ` Arnaldo Carvalho de Melo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aMry3oh_qaV0ZI03@x1 \
    --to=acme@kernel.org \
    --cc=acme@redhat.com \
    --cc=adrian.hunter@intel.com \
    --cc=irogers@google.com \
    --cc=jolsa@kernel.org \
    --cc=leo.yan@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=namhyung@kernel.org \
    --cc=tamas.zsoldos@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.