Re: [PATCH v1] drm/xe/i2c: Rely on d3cold.capable flag in system PM path

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Wed, Sep 17, 2025 at 11:39:29PM +0530, Raag Jadav wrote:
> We don't consider allowed flag for D3cold transition in system PM path.
> Rely on capable flag instead, which reflects root port capability.
> 
> Fixes: 0ea07b69517a ("drm/xe/pm: Wire up suspend/resume for I2C controller")
> Signed-off-by: Raag Jadav <raag.jadav@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_pm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_pm.c b/drivers/gpu/drm/xe/xe_pm.c
> index 17c7dd024343..0014b5f4ad07 100644
> --- a/drivers/gpu/drm/xe/xe_pm.c
> +++ b/drivers/gpu/drm/xe/xe_pm.c
> @@ -198,7 +198,7 @@ int xe_pm_resume(struct xe_device *xe)
>  	if (err)
>  		goto err;
>  
> -	xe_i2c_pm_resume(xe, xe->d3cold.allowed);
> +	xe_i2c_pm_resume(xe, xe->d3cold.capable);

something off here...

When do we need:

xe_mmio_rmw32(mmio, I2C_CONFIG_CMD, 0, PCI_COMMAND_MEMORY | PCI_COMMAND_MASTER);

?

if we need everytime we lose power, you should simply do

xe_i2c_pm_resume(xe, true);

in here, since on s3 we will lose power, regardless the d3cold capable.


>  
>  	xe_irq_resume(xe);
>  
> -- 
> 2.34.1
>