Re: [PATCH 2/2] xfs: use bt_nr_blocks in xfs_dax_translate_range

[Dave Chinner <david@fromorbit.com>]

On Tue, Sep 16, 2025 at 06:52:32AM -0700, Christoph Hellwig wrote:
> Only ranges inside the file system can be translated, and the file system
> can be smaller than the containing device.
> 
> Fixes: f4ed93037966 ("xfs: don't shut down the filesystem for media failures beyond end of log")
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
> ---
>  fs/xfs/xfs_notify_failure.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_notify_failure.c b/fs/xfs/xfs_notify_failure.c
> index fbeddcac4792..3726caa38375 100644
> --- a/fs/xfs/xfs_notify_failure.c
> +++ b/fs/xfs/xfs_notify_failure.c
> @@ -165,7 +165,7 @@ xfs_dax_translate_range(
>  	uint64_t		*bblen)
>  {
>  	u64			dev_start = btp->bt_dax_part_off;
> -	u64			dev_len = bdev_nr_bytes(btp->bt_bdev);
> +	u64			dev_len = BBTOB(btp->bt_nr_blocks);

I'm pretty sure that's wrong based on the first patch -
btp->bt_nr_blocks is in FSB units, not BBs. If bt_nr_blocks is
converted to store the device size in BBs in the first patch like I
suggest, then it's right...

-Dave.
-- 
Dave Chinner
david@fromorbit.com