From: Keith Busch <kbusch@kernel.org>
To: Keith Busch <kbusch@meta.com>
Cc: dm-devel@lists.linux.dev, snitzer@kernel.org,
linux-block@vger.kernel.org, mpatocka@redhat.com,
ebiggers@google.com
Subject: Re: [RFC PATCH] dm-crypt: allow unaligned bio_vecs for direct io
Date: Thu, 18 Sep 2025 14:13:00 -0600 [thread overview]
Message-ID: <aMxnzIavwnJmdAz1@kbusch-mbp> (raw)
In-Reply-To: <20250918161642.2867886-1-kbusch@meta.com>
On Thu, Sep 18, 2025 at 09:16:42AM -0700, Keith Busch wrote:
> + bio_advance_iter_single(ctx->bio_in, &ctx->iter_in, len);
> + bytes -= len;
> + } while (bytes);
> +
> + sg_mark_end(sg_in);
> + sg_in = dmreq->sg_in[0];
Err, there should be an '&' in there, "&dmreq->sg_in[0];"
By the way, I only tested plain64 for the ivmode. That appears to work
fine, but I am aware this will not be successful with elephant, lmk, or
tcw. So just an RFC for now to see if it's worth pursuing.
next prev parent reply other threads:[~2025-09-18 20:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-18 16:16 [RFC PATCH] dm-crypt: allow unaligned bio_vecs for direct io Keith Busch
2025-09-18 20:13 ` Keith Busch [this message]
2025-09-26 14:19 ` Mikulas Patocka
2025-09-26 16:17 ` Keith Busch
2025-09-18 20:27 ` Mike Snitzer
2025-09-18 20:52 ` Keith Busch
2025-09-19 9:13 ` kernel test robot
2025-09-20 5:33 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aMxnzIavwnJmdAz1@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=dm-devel@lists.linux.dev \
--cc=ebiggers@google.com \
--cc=kbusch@meta.com \
--cc=linux-block@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=snitzer@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.