From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 58683CAC5BB for ; Wed, 1 Oct 2025 15:39:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:In-Reply-To:MIME-Version:References: Message-ID:To:Date:Sender:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0sr0qbBr+b5vQxfN8x1/lEAu0jPJ6KI0r43hhe/+cZE=; b=CnSiS0parT9K0eG6HnKXGd/d9N BMdcIjL0u7LKHNyjW3r9ROHQ5SBKSoXSrpRC5RG29YBpW/effiOo+WGWsUW3i07d0H3P4NUFbuKd0 ADTdw0jTw+VgntyMYBKs4TVM82tZaLCio1AWtIPlTUaB69NmnEqbG6wYoSs89Y8mlUcs=; Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1v3yvd-0006Hm-9l; Wed, 01 Oct 2025 15:39:41 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1v3yvb-0006Hc-L7 for linux-f2fs-devel@lists.sourceforge.net; Wed, 01 Oct 2025 15:39:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=o/080FLBJ/6Z5gYnrLHdW84luu2wvuzpy87mly6cJ6M=; b=SMwMrq8Gf6WCykyuTxh/8AGngG u5ib0B47ip0nsJ87niaERAnTMIQ8cWqVJ5HWFClPlc82ZcYGN/gpWsu8PlvATzKPrturX4GeGHw0w NOjumWPJsll8DTCe90WGZPc2wWwG6zsvLLIUfZqnzlyZ37skLLj/deVXKJYIe8qaQDAU=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=o/080FLBJ/6Z5gYnrLHdW84luu2wvuzpy87mly6cJ6M=; b=N1HpMU4LzLoMSBw8grdRmf96Nf 3Xrmrhv8Do84155yyvZNlskWyugkBqJEsKh/jmwirqvSnY3ZJFFM730iVol0U7pU54q6H7dmBeUtR DPml3V2pC9QIwPQvTtNhzADNgSJTIcfGpFdpVLtwpPQ13wTwyupgIal4Wvek0Pz7ddAQ=; Received: from sea.source.kernel.org ([172.234.252.31]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1v3yvb-00078P-5q for linux-f2fs-devel@lists.sourceforge.net; Wed, 01 Oct 2025 15:39:39 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id D76944177A; Wed, 1 Oct 2025 15:39:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5C530C4CEF5; Wed, 1 Oct 2025 15:39:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1759333173; bh=WtEVlB/YEbSlFvYtNBcdguT+bm4fsIj2BYpq1A7Iniw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XgnMXPctSvRuwYy/18hRVob5/ZdSKRwjcttZoPJW9cvfReYnVs79jLDqVP9p3UlUp lgCO02MmMfh8AbPYGs1FFj5Wez195JQWlCDMlsq3nDR9k4CrCgd3gyVf5mK+VAnWWr piJ5zMQSkHv8zmJKBBMBk44Bkg4ZDdTxK/H3befI6YE0ZPDu+GYeXOjwEN7/JeuRON bM3IF8JBEjFWdzAIirezKoDlCWJ5XQzzhJrAEIBG4PmTffoxfkmKVlkdexk9feEiJ2 XX//65JSYAdjxaOMRs31yBiKgQFk6+2dd0YWgt8uw9VbiZbIeYUwUtZXkLK3+34XI2 p3tr0APudIlNg== Date: Wed, 1 Oct 2025 15:39:31 +0000 To: Mateusz Guzik Message-ID: References: <202509301450.138b448f-lkp@intel.com> <20250930232957.14361-1-mjguzik@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250930232957.14361-1-mjguzik@gmail.com> X-Headers-End: 1v3yvb-00078P-5q Subject: Re: [f2fs-dev] [PATCH] f2fs: don't call iput() from f2fs_drop_inode() X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Jaegeuk Kim via Linux-f2fs-devel Reply-To: Jaegeuk Kim Cc: brauner@kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, oe-lkp@lists.linux.dev, oliver.sang@intel.com, linux-fsdevel@vger.kernel.org, josef@toxicpanda.com, ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 10/01, Mateusz Guzik wrote: > iput() calls the problematic routine, which does a ->i_count inc/dec > cycle. Undoing it with iput() recurses into the problem. > > Note f2fs should not be playing games with the refcount to begin with, > but that will be handled later. Right now solve the immediate > regression. > > Fixes: bc986b1d756482a ("fs: stop accessing ->i_count directly in f2fs and gfs2") > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-lkp/202509301450.138b448f-lkp@intel.com > Signed-off-by: Mateusz Guzik > --- > fs/f2fs/super.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c > index 2619cbbd7d2d..26ec31eb8c80 100644 > --- a/fs/f2fs/super.c > +++ b/fs/f2fs/super.c > @@ -1769,7 +1769,7 @@ static int f2fs_drop_inode(struct inode *inode) > sb_end_intwrite(inode->i_sb); > > spin_lock(&inode->i_lock); > - iput(inode); > + atomic_dec(&inode->i_count); It seems this was applied by Josef [1], added in 6.18-rc1. Let me apply this fix after my f2fs pull request, since I don't have this issue in my -next tree yet. [1] https://lore.kernel.org/all/b8e6eb8a3e690ce082828d3580415bf70dfa93aa.1755806649.git.josef@toxicpanda.com/ > } > trace_f2fs_drop_inode(inode, 0); > return 0; > -- > 2.43.0 > _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B4680CCD180 for ; Wed, 1 Oct 2025 15:40:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=lists.linux.it; i=@lists.linux.it; q=dns/txt; s=picard; t=1759333201; h=date : to : message-id : references : mime-version : in-reply-to : subject : list-id : list-unsubscribe : list-archive : list-post : list-help : list-subscribe : from : reply-to : cc : content-type : content-transfer-encoding : sender : from; bh=7hlvbvp9N0BoR7JP0MdpVXjMaoRw/1QJ9CvGjcRSj1o=; b=Ra011egXmPzZbvJFTUWa0TUgkA2Hr/jvMXIJ6q/kh/zDas8IGzQ1Ucb0shaAeg3epWxJQ IeFpwphO3t68f0vlEetJB7AoQob1TY19tF8Dbv5xyo396HMw18yGb/L23ZjD7dwQ1M3lTqG m6ar0Lsp43On6r71UCOxzt5oy3oq5lw= Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 1F7003CE3DA for ; Wed, 1 Oct 2025 17:40:01 +0200 (CEST) Received: from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it [IPv6:2001:4b78:1:20::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id EB0BB3CE37A for ; Wed, 1 Oct 2025 17:39:38 +0200 (CEST) Received: from sea.source.kernel.org (sea.source.kernel.org [IPv6:2600:3c0a:e001:78e:0:1991:8:25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-3.smtp.seeweb.it (Postfix) with ESMTPS id 435621A009AD for ; Wed, 1 Oct 2025 17:39:37 +0200 (CEST) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id D76944177A; Wed, 1 Oct 2025 15:39:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5C530C4CEF5; Wed, 1 Oct 2025 15:39:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1759333173; bh=WtEVlB/YEbSlFvYtNBcdguT+bm4fsIj2BYpq1A7Iniw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XgnMXPctSvRuwYy/18hRVob5/ZdSKRwjcttZoPJW9cvfReYnVs79jLDqVP9p3UlUp lgCO02MmMfh8AbPYGs1FFj5Wez195JQWlCDMlsq3nDR9k4CrCgd3gyVf5mK+VAnWWr piJ5zMQSkHv8zmJKBBMBk44Bkg4ZDdTxK/H3befI6YE0ZPDu+GYeXOjwEN7/JeuRON bM3IF8JBEjFWdzAIirezKoDlCWJ5XQzzhJrAEIBG4PmTffoxfkmKVlkdexk9feEiJ2 XX//65JSYAdjxaOMRs31yBiKgQFk6+2dd0YWgt8uw9VbiZbIeYUwUtZXkLK3+34XI2 p3tr0APudIlNg== Date: Wed, 1 Oct 2025 15:39:31 +0000 To: Mateusz Guzik Message-ID: References: <202509301450.138b448f-lkp@intel.com> <20250930232957.14361-1-mjguzik@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250930232957.14361-1-mjguzik@gmail.com> X-Virus-Scanned: clamav-milter 1.0.7 at in-3.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH] f2fs: don't call iput() from f2fs_drop_inode() X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Jaegeuk Kim via ltp Reply-To: Jaegeuk Kim Cc: brauner@kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, oe-lkp@lists.linux.dev, oliver.sang@intel.com, linux-fsdevel@vger.kernel.org, josef@toxicpanda.com, ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" On 10/01, Mateusz Guzik wrote: > iput() calls the problematic routine, which does a ->i_count inc/dec > cycle. Undoing it with iput() recurses into the problem. > > Note f2fs should not be playing games with the refcount to begin with, > but that will be handled later. Right now solve the immediate > regression. > > Fixes: bc986b1d756482a ("fs: stop accessing ->i_count directly in f2fs and gfs2") > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-lkp/202509301450.138b448f-lkp@intel.com > Signed-off-by: Mateusz Guzik > --- > fs/f2fs/super.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c > index 2619cbbd7d2d..26ec31eb8c80 100644 > --- a/fs/f2fs/super.c > +++ b/fs/f2fs/super.c > @@ -1769,7 +1769,7 @@ static int f2fs_drop_inode(struct inode *inode) > sb_end_intwrite(inode->i_sb); > > spin_lock(&inode->i_lock); > - iput(inode); > + atomic_dec(&inode->i_count); It seems this was applied by Josef [1], added in 6.18-rc1. Let me apply this fix after my f2fs pull request, since I don't have this issue in my -next tree yet. [1] https://lore.kernel.org/all/b8e6eb8a3e690ce082828d3580415bf70dfa93aa.1755806649.git.josef@toxicpanda.com/ > } > trace_f2fs_drop_inode(inode, 0); > return 0; > -- > 2.43.0 > -- Mailing list info: https://lists.linux.it/listinfo/ltp From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 475C92628D; Wed, 1 Oct 2025 15:39:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759333174; cv=none; b=hy/bH+TLsA7cuy70e/AgMQDsg8kZNDjM6rT5QSvcEbqhrs+RJe47o/HtmrAwN2melS83zGKkG8tYnddCsF1cPpdECVLn4dHz2+qh54wxsONUZ3NwX7lVMXlMcU3j19+SQh3fkaK1RLyRPUYOwsHZxHxd1k6QFbR0qwdnMUfjoiU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759333174; c=relaxed/simple; bh=WtEVlB/YEbSlFvYtNBcdguT+bm4fsIj2BYpq1A7Iniw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PQIvgTk3s9B9IfMmF54MKfM477mSyzI2BOU84eeFixNf2NhYuw4nsd9yl5JOe/+ob3d4p9UPP/0l6vCOsB3NnvHHRXZnWkvfrJ5tzBbxYhH4R2Y2ryokE5tAaI2VIQnAa/N5CTUG2L3ex20JSzh6q2iS7VtgFZPnzleZZpxqy58= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=XgnMXPct; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XgnMXPct" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5C530C4CEF5; Wed, 1 Oct 2025 15:39:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1759333173; bh=WtEVlB/YEbSlFvYtNBcdguT+bm4fsIj2BYpq1A7Iniw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XgnMXPctSvRuwYy/18hRVob5/ZdSKRwjcttZoPJW9cvfReYnVs79jLDqVP9p3UlUp lgCO02MmMfh8AbPYGs1FFj5Wez195JQWlCDMlsq3nDR9k4CrCgd3gyVf5mK+VAnWWr piJ5zMQSkHv8zmJKBBMBk44Bkg4ZDdTxK/H3befI6YE0ZPDu+GYeXOjwEN7/JeuRON bM3IF8JBEjFWdzAIirezKoDlCWJ5XQzzhJrAEIBG4PmTffoxfkmKVlkdexk9feEiJ2 XX//65JSYAdjxaOMRs31yBiKgQFk6+2dd0YWgt8uw9VbiZbIeYUwUtZXkLK3+34XI2 p3tr0APudIlNg== Date: Wed, 1 Oct 2025 15:39:31 +0000 From: Jaegeuk Kim To: Mateusz Guzik Cc: brauner@kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, josef@toxicpanda.com, oe-lkp@lists.linux.dev, linux-f2fs-devel@lists.sourceforge.net, ltp@lists.linux.it, oliver.sang@intel.com Subject: Re: [PATCH] f2fs: don't call iput() from f2fs_drop_inode() Message-ID: References: <202509301450.138b448f-lkp@intel.com> <20250930232957.14361-1-mjguzik@gmail.com> Precedence: bulk X-Mailing-List: oe-lkp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250930232957.14361-1-mjguzik@gmail.com> On 10/01, Mateusz Guzik wrote: > iput() calls the problematic routine, which does a ->i_count inc/dec > cycle. Undoing it with iput() recurses into the problem. > > Note f2fs should not be playing games with the refcount to begin with, > but that will be handled later. Right now solve the immediate > regression. > > Fixes: bc986b1d756482a ("fs: stop accessing ->i_count directly in f2fs and gfs2") > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-lkp/202509301450.138b448f-lkp@intel.com > Signed-off-by: Mateusz Guzik > --- > fs/f2fs/super.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c > index 2619cbbd7d2d..26ec31eb8c80 100644 > --- a/fs/f2fs/super.c > +++ b/fs/f2fs/super.c > @@ -1769,7 +1769,7 @@ static int f2fs_drop_inode(struct inode *inode) > sb_end_intwrite(inode->i_sb); > > spin_lock(&inode->i_lock); > - iput(inode); > + atomic_dec(&inode->i_count); It seems this was applied by Josef [1], added in 6.18-rc1. Let me apply this fix after my f2fs pull request, since I don't have this issue in my -next tree yet. [1] https://lore.kernel.org/all/b8e6eb8a3e690ce082828d3580415bf70dfa93aa.1755806649.git.josef@toxicpanda.com/ > } > trace_f2fs_drop_inode(inode, 0); > return 0; > -- > 2.43.0 >