From: Simon Horman <horms@kernel.org>
To: Sreedevi Joshi <sreedevi.joshi@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH v2 iwl-net 1/2] idpf: fix memory leak of flow steer list on rmmod
Date: Wed, 1 Oct 2025 16:43:54 +0100 [thread overview]
Message-ID: <aN1MOnqvkl7nZxZ7@horms.kernel.org> (raw)
In-Reply-To: <20250930212352.2263907-2-sreedevi.joshi@intel.com>
On Tue, Sep 30, 2025 at 04:23:51PM -0500, Sreedevi Joshi wrote:
> The flow steering list maintains entries that are added and removed as
> ethtool creates and deletes flow steering rules. Module removal with active
> entries causes memory leak as the list is not properly cleaned up.
>
> Prevent this by iterating through the remaining entries in the list and
> freeing the associated memory during module removal. Add a spinlock
> (flow_steer_list_lock) to protect the list access from multiple threads.
>
> Fixes: ada3e24b84a0 ("idpf: add flow steering support")
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
> Signed-off-by: Sreedevi Joshi <sreedevi.joshi@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Sreedevi Joshi <sreedevi.joshi@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Subject: Re: [PATCH v2 iwl-net 1/2] idpf: fix memory leak of flow steer list on rmmod
Date: Wed, 1 Oct 2025 16:43:54 +0100 [thread overview]
Message-ID: <aN1MOnqvkl7nZxZ7@horms.kernel.org> (raw)
In-Reply-To: <20250930212352.2263907-2-sreedevi.joshi@intel.com>
On Tue, Sep 30, 2025 at 04:23:51PM -0500, Sreedevi Joshi wrote:
> The flow steering list maintains entries that are added and removed as
> ethtool creates and deletes flow steering rules. Module removal with active
> entries causes memory leak as the list is not properly cleaned up.
>
> Prevent this by iterating through the remaining entries in the list and
> freeing the associated memory during module removal. Add a spinlock
> (flow_steer_list_lock) to protect the list access from multiple threads.
>
> Fixes: ada3e24b84a0 ("idpf: add flow steering support")
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
> Signed-off-by: Sreedevi Joshi <sreedevi.joshi@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-10-01 15:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-30 21:23 [Intel-wired-lan] [PATCH v2 iwl-net 0/2] idpf: fix flow steering issues Sreedevi Joshi
2025-09-30 21:23 ` Sreedevi Joshi
2025-09-30 21:23 ` [Intel-wired-lan] [PATCH v2 iwl-net 1/2] idpf: fix memory leak of flow steer list on rmmod Sreedevi Joshi
2025-09-30 21:23 ` Sreedevi Joshi
2025-10-01 15:43 ` Simon Horman [this message]
2025-10-01 15:43 ` Simon Horman
2025-12-18 0:56 ` [Intel-wired-lan] " Mina Almasry via Intel-wired-lan
2025-12-18 0:56 ` Mina Almasry
2025-09-30 21:23 ` [Intel-wired-lan] [PATCH v2 iwl-net 2/2] idpf: fix issue with ethtool -n command display Sreedevi Joshi
2025-09-30 21:23 ` Sreedevi Joshi
2025-10-01 15:44 ` [Intel-wired-lan] " Simon Horman
2025-10-01 15:44 ` Simon Horman
2025-12-18 0:52 ` [Intel-wired-lan] " Mina Almasry via Intel-wired-lan
2025-12-18 0:52 ` Mina Almasry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aN1MOnqvkl7nZxZ7@horms.kernel.org \
--to=horms@kernel.org \
--cc=aleksandr.loktionov@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
--cc=sreedevi.joshi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.