From: Henrique Soares <henriquegogo@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: How mantainers check Git diffs and patches?
Date: Wed, 1 Oct 2025 23:51:58 -0300 [thread overview]
Message-ID: <aN3ozlH_pPnvdWPn@localhost> (raw)
In-Reply-To: <xmqqh5wi3779.fsf@gitster.g>
On Wed, Oct 01, 2025 at 09:41:46AM -0700, Junio C Hamano wrote:
> Patches are medium for reliable transmission. Once you apply the
> patch to your tree (perhaps giving it its own topic branch, perhaps
> to a detached HEAD with the full intention that you will discard it
> after you are done inspecting the change the patch brings in), you
> can use any regular tools you use while developing and reviewing
> your own code.
It makes totally sense. So I suppose you avoid to review the code just
checking the e-mail patch in e-mail client, but first applying locally
and then check it in your code editor in a separate branch, worktree or
whatever, then back to e-mail thread and comment the code, right?
-- Henrique
next prev parent reply other threads:[~2025-10-02 2:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-01 3:30 How mantainers check Git diffs and patches? Henrique Soares
2025-10-01 8:15 ` Kristoffer Haugsbakk
2025-10-01 21:12 ` Jeff King
2025-10-02 2:43 ` Henrique Soares
2025-10-01 13:37 ` Konstantin Ryabitsev
2025-10-02 2:59 ` Henrique Soares
2025-10-01 16:41 ` Junio C Hamano
2025-10-02 2:51 ` Henrique Soares [this message]
2025-10-02 5:19 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aN3ozlH_pPnvdWPn@localhost \
--to=henriquegogo@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.