All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Bin Guo <guobin@linux.alibaba.com>
Cc: qemu-devel@nongnu.org, hreitz@redhat.com, qemu-block@nongnu.org,
	qemu-trivial@nongnu.org
Subject: Re: [PATCH] block/monitor: Use hmp_handle_error to report error
Date: Thu, 2 Oct 2025 15:28:59 +0200	[thread overview]
Message-ID: <aN5-Cm_2HFZ4wn2Q@redhat.com> (raw)
In-Reply-To: <20250916054850.40963-1-guobin@linux.alibaba.com>

Am 16.09.2025 um 07:48 hat Bin Guo geschrieben:
> According to writing-monitor-commands.rst, best practice is to
> use the 'hmp_handle_error' function, which ensures that the
> message gets an 'Error: ' prefix.
> 
> Signed-off-by: Bin Guo <guobin@linux.alibaba.com>

>      if (!blk_legacy_dinfo(blk)) {
> -        error_report("Deleting device added with blockdev-add"
> +        error_setg(&err, "Deleting device added with blockdev-add"
>                       " is not supported");
>          goto unlock;
>      }

Thanks, fixed up the indentation here and applied to the block branch.

Kevin



      reply	other threads:[~2025-10-02 13:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-16  5:48 [PATCH] block/monitor: Use hmp_handle_error to report error Bin Guo
2025-10-02 13:28 ` Kevin Wolf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aN5-Cm_2HFZ4wn2Q@redhat.com \
    --to=kwolf@redhat.com \
    --cc=guobin@linux.alibaba.com \
    --cc=hreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.