From: Christoph Hellwig <hch@infradead.org>
To: Chuck Lever <cel@kernel.org>
Cc: NeilBrown <neil@brown.name>, Jeff Layton <jlayton@kernel.org>,
Olga Kornievskaia <okorniev@redhat.com>,
Dai Ngo <dai.ngo@oracle.com>, Tom Talpey <tom@talpey.com>,
linux-nfs@vger.kernel.org, Chuck Lever <chuck.lever@oracle.com>
Subject: Re: [PATCH v5 5/6] NFSD: Prevent a NULL pointer dereference in fh_getattr()
Date: Fri, 3 Oct 2025 00:11:07 -0700 [thread overview]
Message-ID: <aN93CyFBPTnmAePM@infradead.org> (raw)
In-Reply-To: <20250929155646.4818-6-cel@kernel.org>
On Mon, Sep 29, 2025 at 11:56:45AM -0400, Chuck Lever wrote:
> From: Chuck Lever <chuck.lever@oracle.com>
>
> In general, fh_getattr() can be called after the target dentry has
> gone negative. For a negative dentry, d_inode(p.dentry) will return
> NULL. S_ISREG() will dereference that pointer.
>
> Avoid this potential regression by using the d_is_reg() helper
> instead.
>
> Suggested-by: NeilBrown <neil@brown.name>
> Fixes: bc70aaeba7df ("NFSD: filecache: add STATX_DIOALIGN and STATX_DIO_READ_ALIGN support")
Fixed for existing bugs should usually go first and/or be split into a
separate prep series.
Otherwise:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2025-10-03 7:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-29 15:56 [PATCH v5 0/6] NFSD direct I/O read Chuck Lever
2025-09-29 15:56 ` [PATCH v5 1/6] NFSD: filecache: add STATX_DIOALIGN and STATX_DIO_READ_ALIGN support Chuck Lever
2025-10-03 7:09 ` Christoph Hellwig
2025-09-29 15:56 ` [PATCH v5 2/6] NFSD: pass nfsd_file to nfsd_iter_read() Chuck Lever
2025-10-03 7:09 ` Christoph Hellwig
2025-09-29 15:56 ` [PATCH v5 3/6] NFSD: Relocate the xdr_reserve_space_vec() call site Chuck Lever
2025-09-29 15:56 ` [PATCH v5 4/6] NFSD: Implement NFSD_IO_DIRECT for NFS READ Chuck Lever
2025-10-03 7:19 ` Christoph Hellwig
2025-10-03 15:06 ` Chuck Lever
2025-09-29 15:56 ` [PATCH v5 5/6] NFSD: Prevent a NULL pointer dereference in fh_getattr() Chuck Lever
2025-09-29 16:13 ` Jeff Layton
2025-09-29 17:39 ` Mike Snitzer
2025-10-03 7:11 ` Christoph Hellwig [this message]
2025-10-03 14:18 ` Chuck Lever
2025-09-29 15:56 ` [PATCH v5 6/6] NFSD: Ignore vfs_getattr() failure in nfsd_file_get_dio_attrs() Chuck Lever
2025-09-29 16:51 ` Jeff Layton
2025-09-29 17:39 ` Mike Snitzer
2025-10-03 7:13 ` Christoph Hellwig
2025-10-03 14:23 ` Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aN93CyFBPTnmAePM@infradead.org \
--to=hch@infradead.org \
--cc=cel@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=dai.ngo@oracle.com \
--cc=jlayton@kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neil@brown.name \
--cc=okorniev@redhat.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.