All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kris Van Hees <kris.van.hees@oracle.com>
To: eugene.loh@oracle.com
Cc: dtrace@lists.linux.dev, dtrace-devel@oss.oracle.com
Subject: Re: [PATCH 4/5] test: Fix antiquated reference to dtrace_ustackdepth_max
Date: Thu, 2 Oct 2025 23:56:21 -0400	[thread overview]
Message-ID: <aN9JZSJBJW6OR7pT@oracle.com> (raw)
In-Reply-To: <20251001062418.6902-4-eugene.loh@oracle.com>

On Wed, Oct 01, 2025 at 02:24:17AM -0400, eugene.loh@oracle.com wrote:
> From: Eugene Loh <eugene.loh@oracle.com>
> 
> Signed-off-by: Eugene Loh <eugene.loh@oracle.com>

Reviewed-by: Kris Van Hees <kris.van.hees@oracle.com>

> ---
>  test/triggers/ustack-tst-bigstack.c | 12 ++++--------
>  1 file changed, 4 insertions(+), 8 deletions(-)
> 
> diff --git a/test/triggers/ustack-tst-bigstack.c b/test/triggers/ustack-tst-bigstack.c
> index e694a518c..267b07e74 100644
> --- a/test/triggers/ustack-tst-bigstack.c
> +++ b/test/triggers/ustack-tst-bigstack.c
> @@ -10,6 +10,10 @@
>  #include <unistd.h>
>  #include <sys/ioctl.h>
>  
> +/*
> + * Create a ridiculously large stack - enough to push us over
> + * the default setting of 'kernel.perf_event_max_stack' (127).
> + */
>  int limit = 4096;
>  
>  int grow1(int);
> @@ -23,14 +27,6 @@ shouldGrow(int frame)
>  int
>  grow(int frame)
>  {
> -	/*
> -	 * Create a ridiculously large stack - enough to push us over
> -	 * the default setting of 'dtrace_ustackdepth_max' (2048).
> -	 *
> -	 * This loop used to repeatedly call getpid(), but on Linux the result
> -	 * of that call gets cached, so that repeated calls actually do not
> -	 * trigger a system call anymore.  We use ioctl() instead.
> -	 */
>  	if (shouldGrow(frame))
>  		frame = grow1(frame++);
>  
> -- 
> 2.47.3
> 

  reply	other threads:[~2025-10-03  3:56 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-01  6:24 [PATCH 1/5] test: Use a more ubiquitous probe for return()-action tests eugene.loh
2025-10-01  6:24 ` [PATCH 2/5] test: Adjust skip file for lockmem problem eugene.loh
2025-10-03  3:52   ` Kris Van Hees
2025-10-01  6:24 ` [PATCH 3/5] test: Fix some ustackdepth tests eugene.loh
2025-10-03  4:07   ` Kris Van Hees
2025-10-09 16:29     ` Kris Van Hees
2025-10-09 21:11       ` Eugene Loh
2025-10-01  6:24 ` [PATCH 4/5] test: Fix antiquated reference to dtrace_ustackdepth_max eugene.loh
2025-10-03  3:56   ` Kris Van Hees [this message]
2025-10-01  6:24 ` [PATCH 5/5] test: Remove antiquated special case for aarch64 eugene.loh
2025-10-03  3:55   ` Kris Van Hees
2025-10-03  3:50 ` [PATCH 1/5] test: Use a more ubiquitous probe for return()-action tests Kris Van Hees

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aN9JZSJBJW6OR7pT@oracle.com \
    --to=kris.van.hees@oracle.com \
    --cc=dtrace-devel@oss.oracle.com \
    --cc=dtrace@lists.linux.dev \
    --cc=eugene.loh@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.