All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: Mark Brown <broonie@kernel.org>
Cc: Srikanth Aithal <sraithal@amd.com>,
	 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	 Linux Next Mailing List <linux-next@vger.kernel.org>,
	Peter Zijlstra <peterz@infradead.org>
Subject: Re: linux-next: manual merge of the kvm-x86 tree with the tip tree
Date: Mon, 22 Sep 2025 07:04:50 -0700	[thread overview]
Message-ID: <aNFXgq3SkvemIlv1@google.com> (raw)
In-Reply-To: <aNE1s02dSgcJ4Uxq@finisterre.sirena.org.uk>

On Mon, Sep 22, 2025, Mark Brown wrote:
> On Mon, Sep 22, 2025 at 04:57:39PM +0530, Aithal, Srikanth wrote:
> > Hello,
> > 
> > Todays linux-next build fails with below error on AMD x86:
> > 
> > arch/x86/kvm/emulate.c:4091:9: error: implicit declaration of function ‘F’
> > [-Werror=implicit-function-declaration]
> >  4091 |         F(DstMem | SrcNone | Lock,              em_inc),
> >       |         ^
> 
> That'll be me doing a mismerge I expect and should've taken the other
> side of the merge for these, I'm quite surprised that the x86
> allmodconfig builds didn't trip this up :( 

Yeah, essentially just s/F/I for the em{inc,dec} entries.

---
 arch/x86/kvm/emulate.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
index beda7030e40a..7d520da8dafc 100644
--- a/arch/x86/kvm/emulate.c
+++ b/arch/x86/kvm/emulate.c
@@ -4088,8 +4088,8 @@ static const struct opcode group4[] = {
 };
 
 static const struct opcode group5[] = {
-	F(DstMem | SrcNone | Lock,		em_inc),
-	F(DstMem | SrcNone | Lock,		em_dec),
+	I(DstMem | SrcNone | Lock,		em_inc),
+	I(DstMem | SrcNone | Lock,		em_dec),
 	I(SrcMem | NearBranch | IsBranch | ShadowStack, em_call_near_abs),
 	I(SrcMemFAddr | ImplicitOps | IsBranch | ShadowStack, em_call_far),
 	I(SrcMem | NearBranch | IsBranch,       em_jmp_abs),

base-commit: bf2602a3cb2381fb1a04bf1c39a290518d2538d1
--

  parent reply	other threads:[~2025-09-22 14:04 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-22  9:50 linux-next: manual merge of the kvm-x86 tree with the tip tree Mark Brown
2025-09-22 11:27 ` Aithal, Srikanth
2025-09-22 11:40   ` Mark Brown
2025-09-22 13:23     ` Mark Brown
2025-09-22 14:04     ` Sean Christopherson [this message]
2025-09-30 18:13 ` Paolo Bonzini
  -- strict thread matches above, loose matches on Subject: below --
2026-03-04 12:21 Mark Brown
2026-03-04 23:10 ` Sean Christopherson
2026-03-05 19:24   ` Nathan Chancellor
2026-03-06 13:24     ` Mark Brown
2026-03-06 22:48       ` Nathan Chancellor
2025-11-25  4:59 Stephen Rothwell
2025-11-25  7:09 ` Borislav Petkov
2025-12-04  5:10 ` Stephen Rothwell
2025-11-20  4:52 Stephen Rothwell
2025-11-20  4:46 Stephen Rothwell
2025-10-20  0:07 Stephen Rothwell
2025-09-19 13:50 Mark Brown
2025-01-06  4:05 Stephen Rothwell
2025-01-09 19:18 ` Sean Christopherson
2025-01-23  3:25 ` Stephen Rothwell
2024-02-07  4:35 Stephen Rothwell
2023-01-19 23:54 Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aNFXgq3SkvemIlv1@google.com \
    --to=seanjc@google.com \
    --cc=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=sraithal@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.