From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Dave Chinner <david@fromorbit.com>,
linux-xfs@vger.kernel.org, jack@suse.cz, lherbolt@redhat.com
Subject: Re: [PATCH 1/2] xfs: rearrange code in xfs_inode_item_precommit
Date: Mon, 22 Sep 2025 11:12:33 -0700 [thread overview]
Message-ID: <aNGRkWGFrt7QOxri@infradead.org> (raw)
In-Reply-To: <20250919160818.GN8096@frogsfrogsfrogs>
On Fri, Sep 19, 2025 at 09:08:18AM -0700, Darrick J. Wong wrote:
> > Not directly related to this patch, but why are we not checking for
> > that in the inode verifier? Even if we can't reject that value,
> > it seems like we should fix that up when reading an inode into memory
> > instead of in a pre-commit hook?
>
> growfs can change rtextsize when adding a rt section to the filesystem,
> and we're not allowed to break userspace (even though I'd wager nobody
> has actually done this in the past 20 years).
Can we document this, please?
next prev parent reply other threads:[~2025-09-22 18:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-17 22:12 [PATCH 0/2] xfs: reduce ILOCK contention on O_DSYNC DIO Dave Chinner
2025-09-17 22:12 ` [PATCH 1/2] xfs: rearrange code in xfs_inode_item_precommit Dave Chinner
2025-09-18 22:49 ` Darrick J. Wong
2025-09-19 15:19 ` Christoph Hellwig
2025-09-19 16:08 ` Darrick J. Wong
2025-09-22 18:12 ` Christoph Hellwig [this message]
2025-09-17 22:12 ` [PATCH 2/2] xfs: rework datasync tracking and execution Dave Chinner
2025-09-19 15:30 ` Christoph Hellwig
2025-09-23 12:12 ` Carlos Maiolino
2025-09-23 13:51 ` [PATCH 0/2] xfs: reduce ILOCK contention on O_DSYNC DIO Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aNGRkWGFrt7QOxri@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=jack@suse.cz \
--cc=lherbolt@redhat.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.