Re: [PATCH] drm/xe/psmi: Do not return NULL

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Mon, Sep 22, 2025 at 03:11:34PM -0700, Lucas De Marchi wrote:
> The checks for id and bo_size are impossible conditions. If they were
> possible, then the caller should not be using IS_ERR(). Just replace
> them with asserts which should be compiled out when not debugging and
> at the same time prevent other refactors to break this assumption.
> 
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Closes: https://lore.kernel.org/r/aK1nZjyAF0s7bnHg@stanley.mountain
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_psmi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_psmi.c b/drivers/gpu/drm/xe/xe_psmi.c
> index 45d142191d600..6a54e38b81ba9 100644
> --- a/drivers/gpu/drm/xe/xe_psmi.c
> +++ b/drivers/gpu/drm/xe/xe_psmi.c
> @@ -70,8 +70,8 @@ static struct xe_bo *psmi_alloc_object(struct xe_device *xe,
>  {
>  	struct xe_tile *tile;
>  
> -	if (!id || !bo_size)
> -		return NULL;
> +	xe_assert(xe, id);
> +	xe_assert(xe, bo_size);
>  
>  	tile = &xe->tiles[id - 1];
>  
> -- 
> 2.50.1
>