Re: [PATCH] drm/xe/configfs: Fix engine class parsing

[Raag Jadav <raag.jadav@intel.com>]

On Tue, Sep 23, 2025 at 10:06:25AM -0500, Lucas De Marchi wrote:
> On Tue, Sep 23, 2025 at 01:33:39PM +0200, Raag Jadav wrote:
> > On Mon, Sep 22, 2025 at 03:12:10PM -0700, Lucas De Marchi wrote:
> > > If mask is NULL, only the engine class should be accepted, so the
> > > pattern string should be completely parsed. This should fix passing e.g.
> > > rcs0 to ctx_restore_post_bb when it's only expecting the engine class.
> > 
> > Should we add to the doc so we don't mix up expectations between different
> > attributes?
> 
> afaics it's already there... it's just the parsing that had a bug for an
> invalid input.
> 
> > 
> > Or do we care about the rest of pattern of mask is NULL? Perhaps it'll
> > allow us to have common expectations between attributes.
> 
> I'm not sure I follow... if mask is NULL, it should only accept the
> engine class. If mask is not null, then it should continue parsing the
> instance (or glob).
> 
> attributes like ctx_restore_post_bb and ctx_restore_mid_bb, use only the
> class, as mentioned in the doc:
> 
>  *      # echo 'rcs cmd 11000001 4F100 DEADBEEF' \                       *

Yes, the "only" part will probably help make it clear, aleast for the folks
who don't have the required "context" :D

Upto you.

Raag