Re: [PATCH 1/2] drm/xe: Fix ggtt fb alignment

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Wed, Sep 24, 2025 at 09:13:03AM +0100, Tvrtko Ursulin wrote:
> Pass the correct alignment from intel_fb_pin_to_ggtt() down to
> __xe_pin_fb_vma().

Just to elaborate a bit, "phys_alignment" is only a thing on
some gen2/3 platforms where the display cursor hardware doesn't
go through GGTT translation and instead takes a direct physical
address instead.

> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
> Reported-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  drivers/gpu/drm/xe/display/xe_fb_pin.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/display/xe_fb_pin.c b/drivers/gpu/drm/xe/display/xe_fb_pin.c
> index 1fd4a815e784..b18d15cc3c53 100644
> --- a/drivers/gpu/drm/xe/display/xe_fb_pin.c
> +++ b/drivers/gpu/drm/xe/display/xe_fb_pin.c
> @@ -378,7 +378,7 @@ intel_fb_pin_to_ggtt(const struct drm_framebuffer *fb,
>  {
>  	*out_flags = 0;
>  
> -	return __xe_pin_fb_vma(to_intel_framebuffer(fb), view, phys_alignment);
> +	return __xe_pin_fb_vma(to_intel_framebuffer(fb), view, alignment);
>  }
>  
>  void intel_fb_unpin_vma(struct i915_vma *vma, unsigned long flags)
> -- 
> 2.48.0

-- 
Ville Syrjälä
Intel