From: Baoquan He <bhe@redhat.com>
To: YoungJun Park <youngjun.park@lge.com>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org, chrisl@kernel.org,
kasong@tencent.com, baohua@kernel.org, shikemeng@huaweicloud.com,
nphamcs@gmail.com
Subject: Re: [PATCH] mm/swapfile.c: select the swap device with default priority round robin
Date: Thu, 25 Sep 2025 12:10:34 +0800 [thread overview]
Message-ID: <aNTAutSpmStbvLip@MiWiFi-R3L-srv> (raw)
In-Reply-To: <aNQTw2JRYfYDcafv@yjaykim-PowerEdge-T330>
On 09/25/25 at 12:52am, YoungJun Park wrote:
> On Wed, Sep 24, 2025 at 05:17:46PM +0800, Baoquan He wrote:
> > - lockdep_assert_held(&si->lock);
> > + //lockdep_assert_held(&si->lock);
> > si->flags &= ~SWP_WRITEOK;
>
> It seems that the commented line `//lockdep_assert_held(&si->lock);`
> should be removed.
Yes, it should be removed. During swapoff, si->lock is taken, while
during swap_range_alloc(), only ci-> is taken. Thanks.
next prev parent reply other threads:[~2025-09-25 4:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-24 9:17 [PATCH] mm/swapfile.c: select the swap device with default priority round robin Baoquan He
2025-09-24 10:23 ` Baoquan He
2025-09-24 15:41 ` YoungJun Park
2025-09-25 2:24 ` Baoquan He
2025-09-24 15:52 ` YoungJun Park
2025-09-25 4:10 ` Baoquan He [this message]
2025-09-25 4:23 ` Baoquan He
2025-09-24 15:54 ` Chris Li
2025-09-24 16:06 ` Chris Li
2025-09-25 2:15 ` Baoquan He
2025-09-25 18:31 ` Chris Li
2025-09-25 1:55 ` Baoquan He
2025-09-25 18:25 ` Chris Li
2025-09-26 15:31 ` Baoquan He
2025-09-27 4:46 ` Chris Li
2025-09-28 2:14 ` Baoquan He
2025-09-24 16:34 ` YoungJun Park
2025-09-25 0:24 ` Baoquan He
2025-09-25 4:36 ` Kairui Song
2025-09-25 6:18 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aNTAutSpmStbvLip@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=chrisl@kernel.org \
--cc=kasong@tencent.com \
--cc=linux-mm@kvack.org \
--cc=nphamcs@gmail.com \
--cc=shikemeng@huaweicloud.com \
--cc=youngjun.park@lge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.