Re: [CI] drm/i915: i915_pmu: Use sysfs_emit() instead of sprintf()

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Wed, Sep 24, 2025 at 10:41:41PM +0200, Andi Shyti wrote:
> From: Madhur Kumar <madhurkumar004@gmail.com>
> 
> Follow the advice in Documentation/filesystems/sysfs.rst:
> show() should only use sysfs_emit() or sysfs_emit_at() when formatting
> the value to be returned to user space.
> 
> Signed-off-by: Madhur Kumar <madhurkumar004@gmail.com>
> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
> Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
> Link: https://lore.kernel.org/r/20250923195051.1277855-1-madhurkumar004@gmail.com
> ---
> Hi,
> 
> I'm resending this patch because unfortunately CI doesn't test
> patches from non allowed users. Although trivial, we need all the
> patches to be tested.

FYI you can just bounce the original mail to intel-gfx and CI will
pick it up.

> 
> Thanks Madhur,
> Andi
> 
>  drivers/gpu/drm/i915/i915_pmu.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_pmu.c b/drivers/gpu/drm/i915/i915_pmu.c
> index 5bc696bfbb0f..d8f69bba79a9 100644
> --- a/drivers/gpu/drm/i915/i915_pmu.c
> +++ b/drivers/gpu/drm/i915/i915_pmu.c
> @@ -895,7 +895,7 @@ static ssize_t i915_pmu_format_show(struct device *dev,
>  	struct i915_str_attribute *eattr;
>  
>  	eattr = container_of(attr, struct i915_str_attribute, attr);
> -	return sprintf(buf, "%s\n", eattr->str);
> +	return sysfs_emit(buf, "%s\n", eattr->str);
>  }
>  
>  #define I915_PMU_FORMAT_ATTR(_name, _config) \
> @@ -925,7 +925,7 @@ static ssize_t i915_pmu_event_show(struct device *dev,
>  	struct i915_ext_attribute *eattr;
>  
>  	eattr = container_of(attr, struct i915_ext_attribute, attr);
> -	return sprintf(buf, "config=0x%lx\n", eattr->val);
> +	return sysfs_emit(buf, "config=0x%lx\n", eattr->val);
>  }
>  
>  #define __event(__counter, __name, __unit) \
> -- 
> 2.51.0

-- 
Ville Syrjälä
Intel