From: Leo Liang <ycliang@andestech.com>
To: Yao Zi <ziyao@disroot.org>
Cc: Rick Chen <rick@andestech.com>, Tom Rini <trini@konsulko.com>,
"Chia-Wei, Wang" <chiawei_wang@aspeedtech.com>,
Simon Glass <sjg@chromium.org>, <u-boot@lists.denx.de>,
E Shattow <e@freeshell.de>
Subject: Re: [PATCH] Revert "riscv: Add a Zalrsc-only alternative for synchronization in start.S"
Date: Fri, 26 Sep 2025 15:51:22 +0800 [thread overview]
Message-ID: <aNZF-ncCfjp3DS7z@swlinux02> (raw)
In-Reply-To: <20250925160148.21624-1-ziyao@disroot.org>
On Thu, Sep 25, 2025 at 04:01:48PM +0000, Yao Zi wrote:
> [EXTERNAL MAIL]
>
> This reverts commit a681cfecb4346107212f377e2075f6eb1bdc6a2b.
>
> It has been reported that the commit causes boot regression for SPL on
> StarFive VisionFive 2 or compatible boards. Inspecting the code, I did
> spot one logic error for deciding whether Zaamo or Zalrsc is used, and
> it's still unclear what exactly causes the regression, let's revert it
> for now.
>
> Reported-by: E Shattow <e@freeshell.de>
> Link: https://lore.kernel.org/u-boot/1871663e-b918-4351-9e9e-97f9a4c73733@freeshell.de/
> Signed-off-by: Yao Zi <ziyao@disroot.org>
> ---
>
> The original series causing the problem[1] contains 3 patches, and I
> think it should be enough to revert the change of start.S only, since
> the others touch no code, and should be relatively safe. I'll fix the
> reverted change up and get it work on VisionFive 2 when I got my new
> board. Sorry for the inconvenience.
>
> [1]: https://lore.kernel.org/u-boot/20250902081932.21103-1-ziyao@disroot.org/
>
> arch/riscv/cpu/start.S | 26 +-------------------------
> 1 file changed, 1 insertion(+), 25 deletions(-)
Acked-by: Leo Yu-Chi Liang <ycliang@andestech.com>
prev parent reply other threads:[~2025-09-26 7:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-25 16:01 [PATCH] Revert "riscv: Add a Zalrsc-only alternative for synchronization in start.S" Yao Zi
2025-09-25 16:27 ` E Shattow
2025-09-26 4:11 ` Yao Zi
2025-10-12 21:49 ` E Shattow
2025-10-13 7:06 ` [SPAM Warning!]Re: " Yao Zi
2025-09-26 7:51 ` Leo Liang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aNZF-ncCfjp3DS7z@swlinux02 \
--to=ycliang@andestech.com \
--cc=chiawei_wang@aspeedtech.com \
--cc=e@freeshell.de \
--cc=rick@andestech.com \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=ziyao@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.